feat: prune env-specific canisters from deploys even in workspaces - #734
Open
adamspofford-dfinity wants to merge 10 commits into
Open
feat: prune env-specific canisters from deploys even in workspaces#734adamspofford-dfinity wants to merge 10 commits into
adamspofford-dfinity wants to merge 10 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Honors dependency-specific environment canister selections within workspaces.
Changes:
- Prunes excluded dependency canisters during manifest consolidation.
- Adjusts member-scoped deployment binding handling.
- Adds tests and documentation for workspace environment selection.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
CHANGELOG.md |
Records the behavior change. |
docs/concepts/environments.md |
Documents workspace selection behavior. |
docs/concepts/project-dependencies.md |
Explains dependency environment precedence. |
crates/icp/src/project.rs |
Consolidates member selections and overrides. |
crates/icp-cli/src/commands/deploy.rs |
Skips missing excluded binding targets. |
crates/icp-cli/tests/dependency_tests.rs |
Adds end-to-end pruning coverage. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
lwshang
reviewed
Aug 26, 2026
lwshang
left a comment
lwshang
left a comment
Contributor
There was a problem hiding this comment.
Read every hunk and verified the first two findings empirically in a throwaway worktree. The partition model reads well and the nested <path>:<canister> resolution is careful, but two cases behave worse than before the change. Details inline.
adamspofford-dfinity
changed the base branch from
main
to
spofford/canister-exclude
August 26, 2026 21:01
adamspofford-dfinity
force-pushed
the
spofford/consistent-env
branch
2 times, most recently
from
August 26, 2026 21:50
936f128 to
81ad117
Compare
adamspofford-dfinity
force-pushed
the
spofford/consistent-env
branch
from
August 26, 2026 22:07
81ad117 to
7ae2e61
Compare
adamspofford-dfinity
force-pushed
the
spofford/consistent-env
branch
from
August 27, 2026 18:03
7ae2e61 to
0e3d03c
Compare
adamspofford-dfinity
changed the base branch from
spofford/canister-exclude
to
main
August 27, 2026 18:06
adamspofford-dfinity
force-pushed
the
spofford/consistent-env
branch
from
September 2, 2026 00:44
0e3d03c to
cd921f0
Compare
raymondk
force-pushed
the
spofford/consistent-env
branch
from
September 8, 2026 14:33
cd921f0 to
7d66b39
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Persisted IDs can still wire excluded canisters after an environment selection is tightened.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 12/12 changed files
- Comments generated: 3
- Review effort level: Balanced
Comment on lines
+681
to
+682
| if !env.canisters.contains_key(target) { | ||
| continue; |
Comment on lines
+26
to
+28
| `icp deploy` deploys **all** of the dependency's canisters into the same environment, not just the exposed ones. A dependency's canisters may call each other, and icp-cli does not track an internal "requires" graph, so the whole dependency is always deployed — exactly as it would deploy on its own. `canisters:` here is an **exposure** filter (which IDs your canisters see), not a deployment filter. | ||
|
|
||
| "Exactly as it would deploy on its own" includes its own environments: if the dependency's environment [names a subset of its canisters](#which-canisters-an-environment-holds), only those are deployed to that environment. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
raymondk
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
icp deploy -e fooshould not deploy any canisters not listed in environmentfoo, but this does not work in workspaces. This PR fixes that.