fix(deps): resolve anyhow and nanoid advisories - #455
Closed
SafraNako wants to merge 1 commit into
Closed
Conversation
- anyhow 1.0.98 -> 1.0.103: RUSTSEC-2026-0190 (Error::downcast_mut unsoundness) - nanoid 3.3.16 -> 3.3.18: GHSA-2v37-7h3g-55p8 (custom generators loop indefinitely when size is zero) Both via cargo update / npm audit fix, within existing manifest ranges. (js-yaml and brace-expansion, also flagged by an earlier scan, are already patched on main via dfinity#445/dfinity#432/dfinity#409; vitest/@vitest-mocker already has dfinity#453/dfinity#454 open for the exact same bump, so left untouched here to avoid duplicating those.) Verified locally: `cargo check --workspace --all-targets` resolves and compiles every dependency (including the bumped anyhow) cleanly; the only failure is the workspace's single member, governance-app-backend, failing at its `include_dir!("../governance-app-frontend/dist")` because that frontend bundle isn't built in my environment -- unrelated to this change (confirmed the same failure exists on unmodified main). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Thank you for contributing! Unfortunately this repository does not accept external contributions yet. We are working on enabling this by aligning our internal processes and our CI setup to handle external contributions. However this will take some time to set up so in the meantime we unfortunately have to close this Pull Request. We hope you understand and will come back once we accept external PRs. — The DFINITY Foundation |
|
✅ No security or compliance issues detected. Reviewed everything up to c501801. Security Overview
Detected Code Changes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Both via `cargo update` / `npm audit fix`, within existing manifest ranges — no manifest changes.
(`js-yaml`/`brace-expansion`, also flagged by my scan, are already patched on `main` via #445/#432/#409. `vitest`/`@vitest/mocker` already has #453/#454 open for the exact same bump, so left untouched here to avoid duplicating those.)
Verified locally
`cargo check --workspace --all-targets` resolves and compiles every dependency (including the bumped `anyhow`) cleanly; the only failure is the workspace's single member, `governance-app-backend`, failing at its `include_dir!("../governance-app-frontend/dist")` because that frontend bundle isn't built in my environment — unrelated to this change (confirmed the same failure exists on unmodified `main`).
🤖 Generated with Claude Code