Skip to content

fix: ic-cdk-bindgen v0.2.1 — escape service type method names in generated bindings #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lwshang merged 1 commit into from
Aug 14, 2026
Merged

fix: ic-cdk-bindgen v0.2.1 — escape service type method names in generated bindings #713

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ license = "Apache-2.0"
[workspace.dependencies]
# Crates of this workspace
ic-cdk = { path = "ic-cdk", version = "0.20.2" }
ic-cdk-bindgen = { path = "ic-cdk-bindgen", version = "0.2.0" }
ic-cdk-bindgen = { path = "ic-cdk-bindgen", version = "0.2.1" }
ic-cdk-bitcoin-canister = { path = "ic-cdk-bitcoin-canister", version = "0.2.0" }
ic-cdk-executor = { path = "ic-cdk-executor", version = "2.0.0" }
ic-cdk-macros = { path = "ic-cdk-macros", version = "=0.20.2" }
Expand All @@ -37,9 +37,11 @@ ic-management-canister-types = "0.7.1"
ic0 = { path = "ic0", version = "1.1.0" }

# Regular dependencies
## sync candid version with the doc comment in ic-cdk/README.md
candid = "0.10.24"
candid_parser = "0.3.0"
# candid_parser v0.4 needs candid >= 0.10.28, but only declares >= 0.10.16.
# Requiring it here keeps a consumer with an older candid pinned in their lockfile from
# resolving to a combination that fails to compile.
candid = "0.10.28"
candid_parser = "0.4.1"
crc32fast = "1.5.0"
darling = "0.23.0"
hex = "0.4"
Expand Down
12 changes: 12 additions & 0 deletions ic-cdk-bindgen/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,18 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [unreleased]

## [0.2.1] - 2026-08-14

### Fixed

- Upgrade `candid_parser` to v0.4.1, which escapes the method names of a service type when
generating the Rust bindings. Previously such a name was emitted raw between the quotes of a Rust
string literal, so a name containing characters that are legal in Candid text but significant in
Rust produced incorrect generated code. Bindings generated from a `.did` file whose service-type
method names are ordinary identifiers are unchanged.
- Raise the minimum `candid` version to v0.10.28, which `candid_parser` v0.4 requires to compile but
does not declare.

## [0.2.0] - 2026-02-19

### New API Design
Expand Down
2 changes: 1 addition & 1 deletion ic-cdk-bindgen/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "ic-cdk-bindgen"
version = "0.2.0"
version = "0.2.1"
authors.workspace = true
edition.workspace = true
license.workspace = true
Expand Down
Loading