Skip to content
Open
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ spec:
{{- if $.Values.kedaAutoscaling.cooldownPeriod }}
cooldownPeriod: {{ $.Values.kedaAutoscaling.cooldownPeriod }}
{{- end }}
{{- if $.Values.kedaAutoscaling.idleReplicaCount }}
{{- if ne $.Values.kedaAutoscaling.idleReplicaCount nil }}
idleReplicaCount: {{ $.Values.kedaAutoscaling.idleReplicaCount }}
{{- end }}
minReplicaCount: {{ $.Values.kedaAutoscaling.minReplicaCount }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ spec:
{{- if $.Values.kedaAutoscaling.cooldownPeriod }}
cooldownPeriod: {{ $.Values.kedaAutoscaling.cooldownPeriod }}
{{- end }}
{{- if $.Values.kedaAutoscaling.idleReplicaCount }}
{{- if ne $.Values.kedaAutoscaling.idleReplicaCount nil }}
idleReplicaCount: {{ $.Values.kedaAutoscaling.idleReplicaCount }}
{{- end }}
minReplicaCount: {{ $.Values.kedaAutoscaling.minReplicaCount }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ spec:
{{- if $.Values.kedaAutoscaling.cooldownPeriod }}
cooldownPeriod: {{ $.Values.kedaAutoscaling.cooldownPeriod }}
{{- end }}
{{- if $.Values.kedaAutoscaling.idleReplicaCount }}
{{- if ne $.Values.kedaAutoscaling.idleReplicaCount nil }}
idleReplicaCount: {{ $.Values.kedaAutoscaling.idleReplicaCount }}
{{- end }}
minReplicaCount: {{ $.Values.kedaAutoscaling.minReplicaCount }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ spec:
{{- if $.Values.kedaAutoscaling.cooldownPeriod }}
cooldownPeriod: {{ $.Values.kedaAutoscaling.cooldownPeriod }}
{{- end }}
{{- if $.Values.kedaAutoscaling.idleReplicaCount }}
{{- if ne $.Values.kedaAutoscaling.idleReplicaCount nil }}
idleReplicaCount: {{ $.Values.kedaAutoscaling.idleReplicaCount }}
{{- end }}
minReplicaCount: {{ $.Values.kedaAutoscaling.minReplicaCount }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ spec:
{{- if $.Values.kedaAutoscaling.cooldownPeriod }}
cooldownPeriod: {{ $.Values.kedaAutoscaling.cooldownPeriod }}
{{- end }}
{{- if $.Values.kedaAutoscaling.idleReplicaCount }}
{{- if ne $.Values.kedaAutoscaling.idleReplicaCount nil }}
idleReplicaCount: {{ $.Values.kedaAutoscaling.idleReplicaCount }}
{{- end }}
minReplicaCount: {{ $.Values.kedaAutoscaling.minReplicaCount }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ spec:
{{- if $.Values.kedaAutoscaling.cooldownPeriod }}
cooldownPeriod: {{ $.Values.kedaAutoscaling.cooldownPeriod }}
{{- end }}
{{- if $.Values.kedaAutoscaling.idleReplicaCount }}
{{- if ne $.Values.kedaAutoscaling.idleReplicaCount nil }}
idleReplicaCount: {{ $.Values.kedaAutoscaling.idleReplicaCount }}
{{- end }}
minReplicaCount: {{ $.Values.kedaAutoscaling.minReplicaCount }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@ kedaAutoscaling:
envSourceContainerName: "" # Optional. Default: .spec.template.spec.containers[0]
cooldownPeriod: 300 # Optional. Default: 300 seconds
minReplicaCount: 1
idleReplicaCount: 0
maxReplicaCount: 2
pollingInterval: 30 # Optional. Default: 30 seconds
# The fallback section is optional. It defines a number of replicas to fallback to if a scaler is in an error state.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ spec:
{{- if $.Values.kedaAutoscaling.cooldownPeriod }}
cooldownPeriod: {{ $.Values.kedaAutoscaling.cooldownPeriod }}
{{- end }}
{{- if $.Values.kedaAutoscaling.idleReplicaCount }}
{{- if ne $.Values.kedaAutoscaling.idleReplicaCount nil }}
idleReplicaCount: {{ $.Values.kedaAutoscaling.idleReplicaCount }}
{{- end }}
minReplicaCount: {{ $.Values.kedaAutoscaling.minReplicaCount }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,7 @@ kedaAutoscaling:
cooldownPeriod: 300 # Optional. Default: 300 seconds
minReplicaCount: 1
maxReplicaCount: 2
idleReplicaCount: 0
pollingInterval: 30 # Optional. Default: 30 seconds
# The fallback section is optional. It defines a number of replicas to fallback to if a scaler is in an error state.
fallback: {} # Optional. Section to specify fallback options
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ spec:
{{- if $.Values.kedaAutoscaling.cooldownPeriod }}
cooldownPeriod: {{ $.Values.kedaAutoscaling.cooldownPeriod }}
{{- end }}
{{- if $.Values.kedaAutoscaling.idleReplicaCount }}
{{- if ne $.Values.kedaAutoscaling.idleReplicaCount nil }}
idleReplicaCount: {{ $.Values.kedaAutoscaling.idleReplicaCount }}
{{- end }}
minReplicaCount: {{ $.Values.kedaAutoscaling.minReplicaCount }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ spec:
{{- if $.Values.kedaAutoscaling.cooldownPeriod }}
cooldownPeriod: {{ $.Values.kedaAutoscaling.cooldownPeriod }}
{{- end }}
{{- if $.Values.kedaAutoscaling.idleReplicaCount }}
{{- if ne $.Values.kedaAutoscaling.idleReplicaCount nil }}
idleReplicaCount: {{ $.Values.kedaAutoscaling.idleReplicaCount }}
{{- end }}
minReplicaCount: {{ $.Values.kedaAutoscaling.minReplicaCount }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ spec:
{{- if $.Values.kedaAutoscaling.cooldownPeriod }}
cooldownPeriod: {{ $.Values.kedaAutoscaling.cooldownPeriod }}
{{- end }}
{{- if $.Values.kedaAutoscaling.idleReplicaCount }}
{{- if ne $.Values.kedaAutoscaling.idleReplicaCount nil }}
idleReplicaCount: {{ $.Values.kedaAutoscaling.idleReplicaCount }}
{{- end }}
minReplicaCount: {{ $.Values.kedaAutoscaling.minReplicaCount }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ spec:
{{- if $.Values.kedaAutoscaling.cooldownPeriod }}
cooldownPeriod: {{ $.Values.kedaAutoscaling.cooldownPeriod }}
{{- end }}
{{- if $.Values.kedaAutoscaling.idleReplicaCount }}
{{- if ne $.Values.kedaAutoscaling.idleReplicaCount nil }}
idleReplicaCount: {{ $.Values.kedaAutoscaling.idleReplicaCount }}
{{- end }}
minReplicaCount: {{ $.Values.kedaAutoscaling.minReplicaCount }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ spec:
{{- if $.Values.kedaAutoscaling.cooldownPeriod }}
cooldownPeriod: {{ $.Values.kedaAutoscaling.cooldownPeriod }}
{{- end }}
{{- if $.Values.kedaAutoscaling.idleReplicaCount }}
{{- if ne $.Values.kedaAutoscaling.idleReplicaCount nil }}
idleReplicaCount: {{ $.Values.kedaAutoscaling.idleReplicaCount }}
{{- end }}
minReplicaCount: {{ $.Values.kedaAutoscaling.minReplicaCount }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ spec:
{{- if $.Values.kedaAutoscaling.cooldownPeriod }}
cooldownPeriod: {{ $.Values.kedaAutoscaling.cooldownPeriod }}
{{- end }}
{{- if $.Values.kedaAutoscaling.idleReplicaCount }}
{{- if ne $.Values.kedaAutoscaling.idleReplicaCount nil }}
idleReplicaCount: {{ $.Values.kedaAutoscaling.idleReplicaCount }}
{{- end }}
minReplicaCount: {{ $.Values.kedaAutoscaling.minReplicaCount }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ spec:
{{- if $.Values.kedaAutoscaling.cooldownPeriod }}
cooldownPeriod: {{ $.Values.kedaAutoscaling.cooldownPeriod }}
{{- end }}
{{- if $.Values.kedaAutoscaling.idleReplicaCount }}
{{- if ne $.Values.kedaAutoscaling.idleReplicaCount nil }}
idleReplicaCount: {{ $.Values.kedaAutoscaling.idleReplicaCount }}
{{- end }}
minReplicaCount: {{ $.Values.kedaAutoscaling.minReplicaCount }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ spec:
{{- if $.Values.kedaAutoscaling.cooldownPeriod }}
cooldownPeriod: {{ $.Values.kedaAutoscaling.cooldownPeriod }}
{{- end }}
{{- if $.Values.kedaAutoscaling.idleReplicaCount }}
{{- if ne $.Values.kedaAutoscaling.idleReplicaCount nil }}
idleReplicaCount: {{ $.Values.kedaAutoscaling.idleReplicaCount }}
{{- end }}
minReplicaCount: {{ $.Values.kedaAutoscaling.minReplicaCount }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ spec:
{{- if $.Values.kedaAutoscaling.cooldownPeriod }}
cooldownPeriod: {{ $.Values.kedaAutoscaling.cooldownPeriod }}
{{- end }}
{{- if $.Values.kedaAutoscaling.idleReplicaCount }}
{{- if ne $.Values.kedaAutoscaling.idleReplicaCount nil }}
idleReplicaCount: {{ $.Values.kedaAutoscaling.idleReplicaCount }}
{{- end }}
minReplicaCount: {{ $.Values.kedaAutoscaling.minReplicaCount }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ spec:
{{- if $.Values.kedaAutoscaling.cooldownPeriod }}
cooldownPeriod: {{ $.Values.kedaAutoscaling.cooldownPeriod }}
{{- end }}
{{- if $.Values.kedaAutoscaling.idleReplicaCount }}
{{- if ne $.Values.kedaAutoscaling.idleReplicaCount nil }}
idleReplicaCount: {{ $.Values.kedaAutoscaling.idleReplicaCount }}
{{- end }}
minReplicaCount: {{ $.Values.kedaAutoscaling.minReplicaCount }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ spec:
{{- if $.Values.kedaAutoscaling.cooldownPeriod }}
cooldownPeriod: {{ $.Values.kedaAutoscaling.cooldownPeriod }}
{{- end }}
{{- if $.Values.kedaAutoscaling.idleReplicaCount }}
{{- if ne $.Values.kedaAutoscaling.idleReplicaCount nil }}
idleReplicaCount: {{ $.Values.kedaAutoscaling.idleReplicaCount }}
{{- end }}
minReplicaCount: {{ $.Values.kedaAutoscaling.minReplicaCount }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ spec:
{{- if $.Values.kedaAutoscaling.cooldownPeriod }}
cooldownPeriod: {{ $.Values.kedaAutoscaling.cooldownPeriod }}
{{- end }}
{{- if $.Values.kedaAutoscaling.idleReplicaCount }}
{{- if ne $.Values.kedaAutoscaling.idleReplicaCount nil }}
idleReplicaCount: {{ $.Values.kedaAutoscaling.idleReplicaCount }}
{{- end }}
minReplicaCount: {{ $.Values.kedaAutoscaling.minReplicaCount }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ spec:
{{- if $.Values.kedaAutoscaling.cooldownPeriod }}
cooldownPeriod: {{ $.Values.kedaAutoscaling.cooldownPeriod }}
{{- end }}
{{- if $.Values.kedaAutoscaling.idleReplicaCount }}
{{- if ne $.Values.kedaAutoscaling.idleReplicaCount nil }}
idleReplicaCount: {{ $.Values.kedaAutoscaling.idleReplicaCount }}
{{- end }}
minReplicaCount: {{ $.Values.kedaAutoscaling.minReplicaCount }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,7 @@ kedaAutoscaling:
cooldownPeriod: 300 # Optional. Default: 300 seconds
minReplicaCount: 1
maxReplicaCount: 2
idleReplicaCount: 0

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lokesh-devtron Why are we including idleReplicaCount: 0 in default values?

@YashasviDevtron previously removed it to fix an issue, can you please verify #6729 once?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@YashasviDevtron YashasviDevtron Jul 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lokesh-devtron idleReplicaCount: 0 was hardcoded into the chart's default values.yaml, so it showed up in every KEDA app's ScaledObject even if the user didn't configure it , meaning pods could get scaled down below minReplicaCount even when user nerver wanted that. That's a problem because it quietly changes behavior: it lets KEDA scale a workload all the way down to zero pods when idle, even for apps that assumed minReplicaCount was a hard floor they'd never drop below, leading to unnecessary downscaling.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the user didn't configure any idleReplicaCount value, it should work purely on minReplicaCount/maxReplicaCount, not silently pick up idleReplicaCount on its own. Removing it from the defaults fixed that, if it's not set, it's just not there, so the manifest skips it and apps go back to their normal min/max replica behavior.

pollingInterval: 30 # Optional. Default: 30 seconds
# The fallback section is optional. It defines a number of replicas to fallback to if a scaler is in an error state.
fallback: {} # Optional. Section to specify fallback options
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ spec:
{{- if $.Values.kedaAutoscaling.cooldownPeriod }}
cooldownPeriod: {{ $.Values.kedaAutoscaling.cooldownPeriod }}
{{- end }}
{{- if $.Values.kedaAutoscaling.idleReplicaCount }}
{{- if ne $.Values.kedaAutoscaling.idleReplicaCount nil }}
idleReplicaCount: {{ $.Values.kedaAutoscaling.idleReplicaCount }}
{{- end }}
minReplicaCount: {{ $.Values.kedaAutoscaling.minReplicaCount }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ autoscaling:
enabled: false
MinReplicas: 1
MaxReplicas: 2
idleReplicaCount: 0
# TargetCPUUtilizationPercentage: 90
# TargetMemoryUtilizationPercentage: 80
annotations: {}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ spec:
{{- if $.Values.kedaAutoscaling.cooldownPeriod }}
cooldownPeriod: {{ $.Values.kedaAutoscaling.cooldownPeriod }}
{{- end }}
{{- if $.Values.kedaAutoscaling.idleReplicaCount }}
{{- if ne $.Values.kedaAutoscaling.idleReplicaCount nil }}
idleReplicaCount: {{ $.Values.kedaAutoscaling.idleReplicaCount }}
{{- end }}
minReplicaCount: {{ $.Values.kedaAutoscaling.minReplicaCount }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ spec:
{{- if $.Values.kedaAutoscaling.cooldownPeriod }}
cooldownPeriod: {{ $.Values.kedaAutoscaling.cooldownPeriod }}
{{- end }}
{{- if $.Values.kedaAutoscaling.idleReplicaCount }}
{{- if ne $.Values.kedaAutoscaling.idleReplicaCount nil }}
idleReplicaCount: {{ $.Values.kedaAutoscaling.idleReplicaCount }}
{{- end }}
minReplicaCount: {{ $.Values.kedaAutoscaling.minReplicaCount }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ spec:
{{- if $.Values.kedaAutoscaling.cooldownPeriod }}
cooldownPeriod: {{ $.Values.kedaAutoscaling.cooldownPeriod }}
{{- end }}
{{- if $.Values.kedaAutoscaling.idleReplicaCount }}
{{- if ne $.Values.kedaAutoscaling.idleReplicaCount nil }}
idleReplicaCount: {{ $.Values.kedaAutoscaling.idleReplicaCount }}
{{- end }}
minReplicaCount: {{ $.Values.kedaAutoscaling.minReplicaCount }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ spec:
{{- if $.Values.kedaAutoscaling.cooldownPeriod }}
cooldownPeriod: {{ $.Values.kedaAutoscaling.cooldownPeriod }}
{{- end }}
{{- if $.Values.kedaAutoscaling.idleReplicaCount }}
{{- if ne $.Values.kedaAutoscaling.idleReplicaCount nil }}
idleReplicaCount: {{ $.Values.kedaAutoscaling.idleReplicaCount }}
{{- end }}
minReplicaCount: {{ $.Values.kedaAutoscaling.minReplicaCount }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ spec:
{{- if $.Values.kedaAutoscaling.cooldownPeriod }}
cooldownPeriod: {{ $.Values.kedaAutoscaling.cooldownPeriod }}
{{- end }}
{{- if $.Values.kedaAutoscaling.idleReplicaCount }}
{{- if ne $.Values.kedaAutoscaling.idleReplicaCount nil }}
idleReplicaCount: {{ $.Values.kedaAutoscaling.idleReplicaCount }}
{{- end }}
minReplicaCount: {{ $.Values.kedaAutoscaling.minReplicaCount }}
Expand Down
Loading