Skip to content

Fix ocelot converter to import transverse deflecting cavities - #676

Open
cr-xu wants to merge 2 commits into
masterfrom
675-ocelot-converter-mistranslates-transverse-deflecting-cavities
Open

Fix ocelot converter to import transverse deflecting cavities#676
cr-xu wants to merge 2 commits into
masterfrom
675-ocelot-converter-mistranslates-transverse-deflecting-cavities

Conversation

@cr-xu

@cr-xu cr-xu commented Jul 27, 2026

Copy link
Copy Markdown
Member

Description

Motivation and Context

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have reformatted the code and checked that formatting passes (required).
  • I have have fixed all issues found by flake8 (required).
  • I have ensured that all pytest tests pass (required).
  • I have run pytest on a machine with a CUDA GPU and made sure all tests pass (required).
  • I have checked that the documentation builds (required).

Note: We are using a maximum length of 88 characters per line.

@cr-xu cr-xu linked an issue Jul 27, 2026 that may be closed by this pull request
@cr-xu

cr-xu commented Jul 27, 2026

Copy link
Copy Markdown
Member Author

Oh, apparently the benchmark test expects to track with ParameterBeam which fails with TDC with only drift-kick-drift method.

We should actually add a linear tracking method for TDC. I'll open another PR for that and wait that to be merged first.

@cr-xu

cr-xu commented Jul 31, 2026

Copy link
Copy Markdown
Member Author

Also, I noticed that the Bmad converter is also missing tdc now, I almost can't believe the issue has been open for so long: #354
Should we just resolve that also here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ocelot converter mistranslates transverse deflecting cavities

1 participant