Fix ocelot converter to import transverse deflecting cavities - #676
Open
cr-xu wants to merge 2 commits into
Open
Fix ocelot converter to import transverse deflecting cavities#676cr-xu wants to merge 2 commits into
cr-xu wants to merge 2 commits into
Conversation
Member
Author
|
Oh, apparently the benchmark test expects to track with ParameterBeam which fails with TDC with only drift-kick-drift method. We should actually add a linear tracking method for TDC. I'll open another PR for that and wait that to be merged first. |
Member
Author
|
Also, I noticed that the Bmad converter is also missing tdc now, I almost can't believe the issue has been open for so long: #354 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Types of changes
Checklist
flake8(required).pytesttests pass (required).pyteston a machine with a CUDA GPU and made sure all tests pass (required).Note: We are using a maximum length of 88 characters per line.