-
Notifications
You must be signed in to change notification settings - Fork 31
Add 2D space charge element #576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
austin-hoover
wants to merge
42
commits into
desy-ml:master
Choose a base branch
from
austin-hoover:sc2d
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 28 commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
9680e87
Add SpaceChargeKick2D class and rename SpaceChargeKick3D
austin-hoover 5012875
Add KV envelope benchmarks
austin-hoover 2f46258
Change SpaceChargeKick to SpaceChargeKick3D/2D in tests
austin-hoover b76a7db
Add SpaceChargeKick2D to conftest.py
austin-hoover 0a1847d
Fix tests
austin-hoover 4530a14
Remove unused files
austin-hoover 705a21d
Move sc2d test to tests/ directory
austin-hoover e8fcbd6
Format
austin-hoover 8fc1cd9
Add test_vectorized
austin-hoover f20d5d6
Add test_incoming_beam_not_modified
austin-hoover c942804
Add test_does_not_break_segment_length
austin-hoover 0a6a777
Copy more tests from sc3d
austin-hoover a0afa32
Format
austin-hoover 2ff793a
Edit docstrings
austin-hoover ff48c96
Format
austin-hoover cfbf272
Format
austin-hoover 212b372
Format
austin-hoover 55c9619
Merge branch 'master' into sc2d
jank324 72a8cb3
Separate space charge kick elements into two separate files
jank324 5017a49
Apply suggestion from @jank324
jank324 a364a17
Apply suggestion from @jank324
jank324 870657a
Apply suggestion from @jank324
jank324 8ead4d5
Rename original space charge kick test file
jank324 b0ea112
Match 2D space charge style to 3D implementation and other Cheetah code
jank324 de676fd
Minor code matching between space charge kick test files
jank324 7dcfd3a
Fix formatting error
jank324 fd249c0
Add changelog entries
jank324 b349e4c
Merge branch 'master' into sc2d
jank324 3ff5b12
Apply suggestion from @Copilot
jank324 d638c42
Fix vectorisation issue pointed out by @Copilot
jank324 6c03c54
Fix error message wording
jank324 86b9c50
Merge branch 'master' into sc2d
jank324 1113565
Reshape beam_length array
austin-hoover 4c0bb6e
Merge branch 'master' into sc2d
jank324 1172bcc
Fix how `beam_length` is reshaped
jank324 321dbf7
Replace 2D space charge kicks with those from 3D
jank324 3abef07
Merge branch 'master' into sc2d
jank324 bf01cd8
Refactor SpaceChargeKick2D to match SpaceChargeKick implementation
jank324 81986a5
Minor code formatting
jank324 887c2da
Various test changes to make 2D and 3D space charge tests match
jank324 de700b2
Fix 2D test
jank324 52819e0
Fix format failure
jank324 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.