Skip to content

Repair wp/7.0 branch Actions: Reference trunk's reusable workflow-lint job - #142

Closed
desrosj wants to merge 1 commit into
fix-actions-7.0/simplify-pr-label-enforcementfrom
fix-actions-7.0/reference-trunk-workflow-lint
Closed

desrosj wants to merge 1 commit into
fix-actions-7.0/simplify-pr-label-enforcementfrom
fix-actions-7.0/reference-trunk-workflow-lint

Conversation

@desrosj

@desrosj desrosj commented Sep 1, 2026

Copy link
Copy Markdown
Owner

What?

Why?

Linting workflow files helps prevent incorrect and/or insecure patterns from being introduced into the codebase.

Use of AI Tools

This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.

@desrosj
desrosj force-pushed the fix-actions-7.0/reference-trunk-workflow-lint branch from e3be481 to edaf670 Compare September 1, 2026 14:04
@desrosj
desrosj force-pushed the fix-actions-7.0/reference-trunk-workflow-lint branch from edaf670 to 8da264f Compare September 10, 2026 18:21
@desrosj
desrosj removed this pull request from stack #151 September 10, 2026 18:21
@desrosj
desrosj changed the base branch from fix-actions-7.0/remove-rn-workflows to fix-actions-7.0/simplify-pr-label-enforcement September 10, 2026 18:21
@desrosj
desrosj added this pull request to stack #179 September 10, 2026 18:22
@desrosj
desrosj force-pushed the fix-actions-7.0/reference-trunk-workflow-lint branch 2 times, most recently from a492c00 to bfc136c Compare September 10, 2026 20:08
@@ -33,4 +41,4 @@
security-events: write
actions: read
contents: read
uses: ./.github/workflows/reusable-workflow-lint.yml
uses: WordPress/gutenberg/.github/workflows/reusable-workflow-lint.yml@trunk
@github-actions

github-actions Bot commented Sep 10, 2026

Copy link
Copy Markdown

Flaky tests detected in 65b0018.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/desrosj/gutenberg/actions/runs/34549551369
📝 Reported tests:

Save flow should work as expected in /test/e2e/specs/editor/various/multi-entity-saving.spec.js, passed after 1 failed attempt.
Error: expect(locator).toBeDisabled() failed

Locator: getByRole('region', { name: 'Editor top bar' }).getByRole('button', { name: 'Saved' })
Expected: disabled
Timeout: 5000ms
Error: element(s) not found

Call log:
  - Expect "toBeDisabled" with timeout 5000ms
  - waiting for getByRole('region', { name: 'Editor top bar' }).getByRole('button', { name: 'Saved' })

    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/various/multi-entity-saving.spec.js:127:5
post title and content are editable and blocks can be inserted in /test/e2e/specs/editor/various/post-content-focus-mode.spec.js, passed after 1 failed attempt.
TimeoutError: locator.getAttribute: Timeout 10000ms exceeded.
Call log:
  - waiting for locator('[name="editor-canvas"]').contentFrame().getByText('Initial content')

    at Editor.selectBlocks (/home/runner/work/gutenberg/gutenberg/packages/e2e-test-utils-playwright/src/editor/select-blocks.ts:26:41)
    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/various/post-content-focus-mode.spec.js:163:18
    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/various/post-content-focus-mode.spec.js:159:15
should move focus back to the Publish panel toggle button when canceling in /test/e2e/specs/editor/various/publish-panel.spec.js, passed after 1 failed attempt.
Error: expect(locator).toBeFocused() failed

Locator:  locator('role=region[name="Editor top bar"i]').locator('role=button[name="Publish"i]')
Expected: focused
Received: inactive
Timeout:  5000ms

Call log:
  - Expect "toBeFocused" with timeout 5000ms
  - waiting for locator('role=region[name="Editor top bar"i]').locator('role=button[name="Publish"i]')
    9 × locator resolved to <button type="button" aria-expanded="true" aria-disabled="false" class="components-button editor-post-publish-panel__toggle editor-post-publish-button__button is-primary is-compact">Publish</button>
      - unexpected value "inactive"

    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/various/publish-panel.spec.js:33:44

@desrosj
desrosj force-pushed the fix-actions-7.0/reference-trunk-workflow-lint branch from bfc136c to 195583c Compare September 10, 2026 23:47
@desrosj
desrosj marked this pull request as ready for review September 11, 2026 00:55
@desrosj
desrosj force-pushed the fix-actions-7.0/reference-trunk-workflow-lint branch from 195583c to 65b0018 Compare September 11, 2026 01:09
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: desrosj <desrosj@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@desrosj
desrosj marked this pull request as draft September 11, 2026 03:21
Removes the local `reusable-workflow-lint.yml` and points
`workflow-lint.yml` at
`WordPress/gutenberg/.github/workflows/reusable-workflow-lint.yml@trunk`
instead, so this branch always lints against trunk's current lint
logic rather than a stale local copy.

Also widens `workflow-lint.yml`'s own `push`/`pull_request` branch
filters from `trunk` only to also include `release/[0-9]+.[0-9]`,
`wp/[0-9]+.[0-9]`, `wp/latest`, and `wp/next` — porting
`WordPress#82744`'s fix for this file. Without this, pushes
or pull requests targeting this branch itself never triggered linting
at all, since `trunk` was the only branch the filter recognized.
@desrosj
desrosj force-pushed the fix-actions-7.0/reference-trunk-workflow-lint branch from 65b0018 to 1292fd5 Compare September 11, 2026 17:03
@desrosj
desrosj marked this pull request as ready for review September 11, 2026 18:15
@desrosj

desrosj commented Sep 11, 2026

Copy link
Copy Markdown
Owner Author

Migrated to real upstream: WordPress#82799. Closing this fork PR.

@desrosj desrosj closed this Sep 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants