feat(xaa): expose the read-only project-level audience on the XAA load response - #839
Conversation
…d response LoadXAASettings now returns the audience a requesting application must present in its ID-JAG token, so API and Terraform users read the same value the console and the SSO setup suite show instead of building it by hand. It is project-level and names no tenant - the IdP sends the tenant in the token's aud_tenant claim. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
🐕 Review complete — View session on Shuni Portal 🐾 |
🐕 Suggested ReviewersThis PR adds a read-only
Suggested by Shuni based on git history and PR context. Names are not @-mentioned to avoid notifying anyone — request a review from whoever fits best. |
There was a problem hiding this comment.
🐕 Shuni Review
Adds a read-only Audience field to SSOXAASettingsResponse so XAA load responses expose the project-level audience.
Actionable comments posted: 0
Merge risk: 🟢 Low: purely additive field with generic JSON unmarshal covering both single and bulk load paths, kept out of the write-payload struct to preserve read-only semantics, and covered by a passing test assertion.
Review scope: Full review
Reviewed files (2)
descope/types.godescope/internal/mgmt/sso_test.go
Related Issues
Required for:
https://github.com/descope/etc/issues/18013
Related PRs
Upstream PRs
Related PRs
In a Nutshell
audienceon the XAA load responseDescription
Loading Cross-App Access settings now also returns the audience a requesting application has to present in its ID-JAG token, so callers read the same value the console shows instead of building it themselves. It has no tenant in it - the identity provider sends the tenant in the token's
aud_tenantclaim.Must