Skip to content

Cleanup: Eliminate echo usage for API error responses #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
idofri wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Cleanup: Eliminate echo usage for API error responses #56

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/SDK/API.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,7 @@ public function doPost(string $uri, array $body, ?bool $useManagementKey = false
} catch (RequestException $e) {
$statusCode = $e->getResponse() ? $e->getResponse()->getStatusCode() : 'N/A';
$responseBody = $e->getResponse() ? $e->getResponse()->getBody()->getContents() : 'No response body';
echo "RequestException: " . $e->getMessage() . "\n";
echo "Error: HTTP Status Code: $statusCode, Response: $responseBody\n";

return [
'statusCode' => $statusCode,
'response' => $responseBody,
Expand Down Expand Up @@ -169,7 +168,7 @@ public function doGet(string $uri, bool $useManagementKey, ?string $refreshToken
} catch (RequestException $e) {
$statusCode = $e->getResponse() ? $e->getResponse()->getStatusCode() : 'N/A';
$responseBody = $e->getResponse() ? $e->getResponse()->getBody()->getContents() : 'No response body';
echo "Error: HTTP Status Code: $statusCode, Response: $responseBody";

return [
'statusCode' => $statusCode,
'response' => $responseBody,
Expand Down Expand Up @@ -210,7 +209,7 @@ public function doDelete(string $uri): array
} catch (RequestException $e) {
$statusCode = $e->getResponse() ? $e->getResponse()->getStatusCode() : 'N/A';
$responseBody = $e->getResponse() ? $e->getResponse()->getBody()->getContents() : 'No response body';
echo "Error: HTTP Status Code: $statusCode, Response: $responseBody";

return [
'statusCode' => $statusCode,
'response' => $responseBody,
Expand Down