Fix Windows build#117
Open
petrochenkov wants to merge 1 commit into
Open
Conversation
Member
Yeah. Please follow up if you don't see movement in a few days. |
Author
ping @pfmooney |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This crate unfortunately has ambiguous glob imports (rust-lang/rust#114095) in
src/sys/windows/mod.rs, so it fails building on modern versions of rustc.Other crates depending on
net2are not affected yet, becauseambiguous_glob_importsis a lint, but when the lint is converted to an error they will stop building too.Some crates depending on
net2(e.g.iron) were quite popular in the past, so in rust-lang/rust#149195 we had to add a crate-specific exception to rustc to keepnet2building.@pfmooney I understand that the crate is long deprecated, but would it be possible to release a patch version of this crate with this fix?
It would make life easier for both rustc and all its transitive dependencies that still may be in use.