fix(gemini): sanitize schema keywords in function responses to prevent 400 - #3411
Open
AhooraZen wants to merge 1 commit into
Open
fix(gemini): sanitize schema keywords in function responses to prevent 400#3411AhooraZen wants to merge 1 commit into
AhooraZen wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When tool output (e.g. from
webfetchor JSON schema files) contains keys like$ref,$defs,#, or/,tryParseJSONparses them into thefunctionResponse.responseobject.Google Gemini / Antigravity protobuf parser treats these keys as schema references rather than payload data, failing with:
{"error":{"code":400,"message":"The referenced name `#/$defs/Config` in function_response.response does not match to a display_name in the function_response.parts.","status":"INVALID_ARGUMENT"}}Solution
sanitizeFunctionResponseResultinopen-sse/translator/formats/gemini.jsto recursively sanitize forbidden schema characters ($,#,/,definitions) in tool result objects before constructingfunctionResponse.scripts/test-gemini-tool-response-sanitization.mjs.