fix(commandcode): strip thinking suffix from params.model - #3408
Open
naufalmalikr wants to merge 1 commit into
Open
fix(commandcode): strip thinking suffix from params.model#3408naufalmalikr wants to merge 1 commit into
naufalmalikr wants to merge 1 commit into
Conversation
Upstream reads params.model and rejects unknown ids. The client thinking suffix "model(level)" was copied verbatim into params.model (chatCore strips only the top-level model field), so requests like gpt-5.6-luna(max) failed with 403 "Model/provider not recognized: anthropic:gpt-5.6-luna(max)". Strip the suffix in the commandcode translator; applyThinking still consumes the suffix for the thinking override before the body is sent.
afandiaziz
added a commit
to afandiaziz/9router
that referenced
this pull request
Aug 20, 2026
afandiaziz
added a commit
to afandiaziz/9router
that referenced
this pull request
Aug 20, 2026
…/security/providers Verified via trial-merge + per-PR tests (84 pass/0 fail), OAuth baseline identical, providers baseline additive-only (+reasonix/ovh/joycode/openmodel). PRs: decolua#3411 decolua#3370 decolua#3369 decolua#3368 decolua#3393 decolua#3366 decolua#3395 decolua#3382 decolua#3359 decolua#3408 decolua#3357 decolua#3379 decolua#3380 decolua#3381 decolua#3396 decolua#3338 Co-Authored-By: Claude <noreply@anthropic.com>
rabbi696
pushed a commit
to golamrabbi696/EzRouter
that referenced
this pull request
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Requests to the CommandCode provider fail with a 403 when the client sends a thinking-level suffix on the model id:
The upstream
/alpha/generateAPI reads the model fromparams.modeland rejects unknown ids — agpt-5.6-luna(max)is not a valid upstream model, so the gateway falls back to ananthropic:family guess and 403s.Root cause
getModelUpstreamId(providerModels.js) intentionally re-appends the client's thinking suffix(max)soapplyThinkingcan consume it.chatCore.jsstrips the suffix from the top-leveltranslatedBody.modelbefore dispatch.params.modelverbatim — the suffix leaks to the wire.Proof from a real failing request (
requestDetails):Fix
Strip the thinking suffix when setting
params.modelinopenaiToCommandCodeRequest(reusingstripThinkingSuffixfromthinkingUnified.js). The suffix is still consumed byapplyThinkingfor the thinking override; only the wire model is cleaned.Verified: plain
gpt-5.6-lunasucceeds upstream;gpt-5.6-luna(max)was the only difference.Tests
tests/unit/openai-to-commandcode.test.js(suffix stripped for plain and family-prefixed ids, plain ids untouched).npx vitest run unit/openai-to-commandcode.test.js→ 14/14 pass.it.fails).npx eslintclean.