feat(sdk): enable OTEL error promotion at 100% by default#303
Open
igoramf wants to merge 1 commit into
Open
Conversation
Flip DECO_OTEL_ERROR_PROMOTION default to true and DECO_OTEL_ERROR_PROMOTION_RATE default to 1 so error traces always ship to ClickHouse without callers having to opt in. Set DECO_OTEL_ERROR_PROMOTION=false to opt out. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
nicacioliveira
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DECO_OTEL_ERROR_PROMOTIONdefault fromfalse→trueso anylogger.error()with an active trace context promotes the trace for export.DECO_OTEL_ERROR_PROMOTION_RATEdefault from0.1→1(100% of promoted error traces are kept).DECO_OTEL_ERROR_PROMOTION=false.Only
level === "error"triggers promotion (seesrc/sdk/otelHttpLog.ts:228) — warns are unaffected.Test plan
DECO_OTEL_ERROR_PROMOTION=falseand confirm promotion is disabled.🤖 Generated with Claude Code
Summary by cubic
Enable OTEL error promotion (
DECO_OTEL_ERROR_PROMOTION) by default and set its sampling rate to 100%, so traces forlogger.error()are exported even when head sampling skips them. Opt out withDECO_OTEL_ERROR_PROMOTION=false, or tune volume viaDECO_OTEL_ERROR_PROMOTION_RATE(0.0–1.0).Written for commit 458cdc1. Summary will update on new commits.