fix(admin): add postMessage origin validation to liveControls.ts#208
Open
0xcucumbersalad wants to merge 1 commit into
Open
fix(admin): add postMessage origin validation to liveControls.ts#2080xcucumbersalad wants to merge 1 commit into
0xcucumbersalad wants to merge 1 commit into
Conversation
Align liveControls.ts with LiveControls.tsx by adding TRUSTED_ORIGINS allowlist and isTrustedOrigin() check. Without this, any page that iframes the storefront can execute arbitrary JS via postMessage. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
hugo-ccabral
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TRUSTED_ORIGINSallowlist andisTrustedOrigin()check tosrc/admin/liveControls.ts, matching the existing fix inLiveControls.tsxpostMessage— a framework-level XSS*.deco.cxsubdomain, and same-origin messagesTest plan
bun run test— 46 files, 687 tests passed🤖 Generated with Claude Code
Summary by cubic
Adds origin validation to the admin live controls postMessage handler to block untrusted iframes and prevent script injection when the storefront is embedded. Aligns
src/admin/liveControls.tswithLiveControls.tsxby allowing only deco.cx origins and same-origin messages.TRUSTED_ORIGINSandisTrustedOrigin(); ignore messages whenevent.originis not trusted.https://deco.cx,https://admin.deco.cx,https://play.deco.cx, any*.deco.cxsubdomain, and same-origin.Written for commit 3adb2db. Summary will update on new commits.