Repository navigation
feat(bigquery): support data governance tags on columns - #16694
Open
AxelThevenot wants to merge 1 commit into
Open
AxelThevenot wants to merge 1 commit into
AxelThevenot wants to merge 1 commit into
Conversation
Expose BigQuery data governance tags through column properties and apply them during persisted column documentation. BigQuery DDL currently limits this path to top-level table columns. Refs dbt-labs#16693
There was a problem hiding this comment.
Gates Failed
Enforce advisory code health rules
(1 file with Large Method)
Our agent can fix these. Install it.
Gates Passed
3 Quality Gates Passed
Reason for failure
| Enforce advisory code health rules | Violations | Code Health Impact | |
|---|---|---|---|
| utils.rs | 1 advisory rule | 5.01 → 5.01 | Suppress |
Quality Gate Profile: Clean Code Collective
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.
| meta: existing.map(|col| col.meta.clone()).unwrap_or_default(), | ||
| tags: existing.map(|col| col.tags.clone()).unwrap_or_default(), | ||
| policy_tags: existing.and_then(|col| col.policy_tags.clone()), | ||
| data_governance_tags: existing.and_then(|col| col.data_governance_tags.clone()), |
There was a problem hiding this comment.
❌ Getting worse: Large Method
update_node_columns increases from 70 to 71 lines of code, threshold = 70
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #16693
Problem
BigQuery supports data governance tags for column-level access control, and dbt column properties cannot declare or apply them.
Solution
Add a
data_governance_tagscolumn property with one namespaced key and one value short name. Whenpersist_docs.columnsis enabled, dbt emits oneALTER TABLEthat sets the tag on each supported column.Supported:
key: <project-or-organization>/<tag-key>value: <tag-value-short-name>Not supported:
Checklist