feat: add ImageCatalog.componentImages from CNPG 1.30.0 - #941
Open
timgriffiths wants to merge 1 commit into
Open
feat: add ImageCatalog.componentImages from CNPG 1.30.0#941timgriffiths wants to merge 1 commit into
timgriffiths wants to merge 1 commit into
Conversation
CloudNativePG 1.30.0 added spec.componentImages so Poolers can pin the PgBouncer image via an ImageCatalog or ClusterImageCatalog. The catalog schemas still reject the field (additionalProperties: false), which breaks kubeconform for any manifest that uses it. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Updated schema version: CloudNativePG 1.30.0 (Helm chart
cloudnative-pg0.29.0).Source CRDs: https://github.com/cloudnative-pg/cloudnative-pg/tree/v1.30.0/config/crd/bases
Release: https://github.com/cloudnative-pg/cloudnative-pg/releases/tag/v1.30.0
Method
I did not extract from a live cluster. I converted the official v1.30.0 CRDs with the same
openapi2jsonschema.pyscript the CRD Extractor uses:What changed
CNPG 1.30.0 added
spec.componentImagesso aPoolercan pin the PgBouncer image viaspec.pgbouncer.imageCatalogRef(cloudnative-pg#10568). The catalog schemas still haveadditionalProperties: falseonspecand only allowimages, so kubeconform rejects any ImageCatalog that setscomponentImages.This updates:
postgresql.cnpg.io/imagecatalog_v1.jsonpostgresql.cnpg.io/clusterimagecatalog_v1.json(same spec)Also picks up the 1.30.0
extensions[].namemaxLength: 59clarification from the same CRDs. Other CNPG resources were left unchanged.Made with Cursor