fix: add InPlace to VerticalPodAutoscaler v1 updateMode enum - #914
Open
starlightromero wants to merge 1 commit into
Open
fix: add InPlace to VerticalPodAutoscaler v1 updateMode enum#914starlightromero wants to merge 1 commit into
starlightromero wants to merge 1 commit into
Conversation
Add "InPlace" as a valid updateMode value for the VerticalPodAutoscaler v1 schema. This mode was introduced in VPA 1.7.0 as an alpha feature. InPlace mode resizes pod resources without restart or eviction. Unlike InPlaceOrRecreate, it never falls back to eviction — if a resize cannot be applied it defers and retries. Requires Kubernetes 1.33+ with InPlacePodVerticalScaling feature gate and VPA --feature-gates=InPlace=true. Ref: https://kubernetes.io/docs/concepts/workloads/autoscaling/vertical-pod-autoscale/#updateMode-InPlace Fixes: datreeio#913
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
InPlaceas a validupdateModevalue for the VerticalPodAutoscaler v1 schema (autoscaling.k8s.io/verticalpodautoscaler_v1.json).Context
The
InPlaceupdate mode was introduced in VPA 1.7.0 as an alpha feature. It resizes pod resources (CPU/memory) without restart or eviction — if a resize cannot be applied, it defers and retries on the next reconciliation loop.Currently, users with VPA 1.7.0+ using
updateMode: InPlaceget false validation failures from kubeconform when using this catalog as a schema source.Change
References
InPlacePodVerticalScalingfeature gate + VPA--feature-gates=InPlace=trueFixes #913