Skip to content

Surface file cleanup failures #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cragkhit wants to merge 1 commit into
base: 1.x
Choose a base branch
from
Open

Surface file cleanup failures #533

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion tests/src/main/java/com/datastax/oss/dsbulk/tests/utils/FileUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,9 @@ public FileVisitResult visitFile(Path file, BasicFileAttributes attrs)
@Override
public FileVisitResult postVisitDirectory(Path dir, IOException exc)
throws IOException {
if (exc != null) {
throw exc;
}
// Do not delete directories on Windows as deletes are not executed immediately,
// but they do result in an IO exception the next time we try to access a directory in
// pending-deletion state. Leaving directories empty is good enough for DSBulk anyway,
Expand All @@ -111,7 +114,8 @@ public FileVisitResult postVisitDirectory(Path dir, IOException exc)
return FileVisitResult.CONTINUE;
}
});
} catch (IOException ignored) {
} catch (IOException e) {
throw new UncheckedIOException(e);
}
}

Expand Down