Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion public/Import-DbaParquet.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,12 @@ function Import-DbaParquet {
param([string]$Path)
$stream = [System.IO.File]::OpenRead($Path)
try {
$reader = [Parquet.ParquetReader]::CreateAsync($stream).GetAwaiter().GetResult()
# leaveStreamOpen has to be passed as false. It defaults to true, which means disposing the
# reader leaves the file stream open and the file stays locked until the garbage collector
# finalizes it - so the imported file could not be deleted or overwritten for an arbitrary
# time after the import finished. All four arguments are passed because the overload that
# takes a stream can only be selected by its full signature.
$reader = [Parquet.ParquetReader]::CreateAsync($stream, $null, $false, [System.Threading.CancellationToken]::None).GetAwaiter().GetResult()
return $reader
} catch {
$stream.Dispose()
Expand Down