Skip to content

Query Store - Silence the expected warnings of the system database tests #10535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potatoqualitee merged 2 commits into from
Aug 9, 2026
+6 −4
Merged

Query Store - Silence the expected warnings of the system database tests #10535

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3127b7
Query Store - Silence the expected warnings of the system database tests
andreasjordan Aug 8, 2026
dc9f7a9
Merge branch 'development' into fix-querystore-test-warnings
potatoqualitee Aug 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions tests/Get-DbaDbQueryStoreOption.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,14 +34,16 @@ Describe $CommandName -Tag IntegrationTests {

Context "When a system database is named explicitly" {
It "Warns about master and tempdb instead of silently returning nothing" {
$resultsSystemDb = Get-DbaDbQueryStoreOption -SqlInstance $TestConfig.InstanceSingle -Database master, tempdb -WarningVariable warnSystemDb
$resultsSystemDb = Get-DbaDbQueryStoreOption -SqlInstance $TestConfig.InstanceSingle -Database master, tempdb -WarningVariable warnSystemDb -WarningAction SilentlyContinue
$resultsSystemDb | Should -BeNullOrEmpty
$warnSystemDb -join "`n" | Should -Match "Query Store cannot be enabled on system database master"
$warnSystemDb -join "`n" | Should -Match "Query Store cannot be enabled on system database tempdb"
}

It "Reads model from SQL Server 2022 on and warns about it before that" {
$resultsModel = Get-DbaDbQueryStoreOption -SqlInstance $TestConfig.InstanceSingle -Database model -WarningVariable warnModel
# Silenced because the pre-2022 branch below expects a warning. The warning is still
# captured in $warnModel, so an unexpected one on 2022 and later fails the assertion.
$resultsModel = Get-DbaDbQueryStoreOption -SqlInstance $TestConfig.InstanceSingle -Database model -WarningVariable warnModel -WarningAction SilentlyContinue

if ($serverSingle.VersionMajor -ge 16) {
$resultsModel.Database | Should -Be "model"
Expand Down
4 changes: 2 additions & 2 deletions tests/Set-DbaDbQueryStoreOption.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ Describe $CommandName -Tag IntegrationTests {
}

It "Warns about master and tempdb instead of doing nothing at all" {
$resultsSystemDb = Set-DbaDbQueryStoreOption -SqlInstance $TestConfig.InstanceMulti1 -Database master, tempdb -State ReadWrite -WarningVariable warnSystemDb
$resultsSystemDb = Set-DbaDbQueryStoreOption -SqlInstance $TestConfig.InstanceMulti1 -Database master, tempdb -State ReadWrite -WarningVariable warnSystemDb -WarningAction SilentlyContinue
$resultsSystemDb | Should -BeNullOrEmpty
$warnSystemDb -join "`n" | Should -Match "Query Store cannot be enabled on system database master"
$warnSystemDb -join "`n" | Should -Match "Query Store cannot be enabled on system database tempdb"
Expand All @@ -138,7 +138,7 @@ Describe $CommandName -Tag IntegrationTests {
$null = Set-DbaDbQueryStoreOption -SqlInstance $TestConfig.InstanceMulti1 -Database model -StaleQueryThreshold $originalThreshold
}
} else {
$resultsModel = Set-DbaDbQueryStoreOption -SqlInstance $TestConfig.InstanceMulti1 -Database model -StaleQueryThreshold 45 -WarningVariable warnModel
$resultsModel = Set-DbaDbQueryStoreOption -SqlInstance $TestConfig.InstanceMulti1 -Database model -StaleQueryThreshold 45 -WarningVariable warnModel -WarningAction SilentlyContinue
$resultsModel | Should -BeNullOrEmpty
$warnModel -join "`n" | Should -Match "Query Store cannot be read on model before SQL Server 2022"
}
Expand Down