feat: model prep target assoc logs - #273
Draft
nm3224 wants to merge 4 commits into
Draft
Conversation
printing top 5 corrs/assoc so DS can manually force include as needed
…lf the peak positive corr) and up to 3 strongest negative families (most negative first, one per family)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Printing in modeling task under
model_prep.log:top 5 corrs (distinct values)
bottom 5 corrs (distinct values)
top 5 assocs (distinct values)
So DS can manually force include predictive features that may be dropped due to VIF as needed without having to look at this in a notebook when troubleshooting poor metrics.
Asana Task
https://app.asana.com/1/6325821815997/project/1208486153653829/task/1217170012807228
see test run in task comments
Deployment Readiness*
Testing
Describe or check:
Deployment Notes
Describe or check:
Rollback Plan
Describe or check:
git revert)Reviewer Guidance / Questions*
Screenshots / Testing Evidence*
SOC 2 Change Management Checklist
./vendor/bin/pest)Provide justification if you are submitting a PR with any boxes checked other than the first.
Reminder for Reviewers: By approving this PR you are confirming that you have reviewed the code for correctness, security, and compliance with our engineering and SOC 2 standards. Do not approve PRs where SOC 2 checklist items are checked without documented justification.
*Optional