Read login_name and display_name back for service users - #71
Read login_name and display_name back for service users#71jacodegroothydrab wants to merge 1 commit into
Conversation
|
The The branch now conflicts with current Please also shorten the seven-line rationale above the changed |
fetch_user discards login_name and display_name for TYPE = SERVICE, so the provider reports None whatever the account holds. A config declaring either gets a diff that can never converge: applying it changes nothing, and the next plan proposes it again. SHOW USERS reports both for service users. Only must_change_password is genuinely unreadable for TYPE = SERVICE, so that stays blanked. It also defeats the point of declaring login_name at all. ALTER USER ... RENAME TO leaves LOGIN_NAME behind, and a field the provider always reads as None can never surface that drift. Adds 6 unit tests over fetch_user, which had none. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
1f78e5b to
1f49ca4
Compare
|
Rebased onto main — the conflict in Trimmed the rationale to |
fetch_userdiscardslogin_nameanddisplay_nameforTYPE = SERVICE:SHOW USERShas already returned both. The provider reportsNoneregardless, so a config declaring either gets a diff that can never converge — applying it changes nothing and the next plan proposes it again.Only
must_change_passwordis genuinely unreadable for a service user, so that stays blanked.It also defeats the point of declaring
login_name:ALTER USER ... RENAME TOleavesLOGIN_NAMEbehind, and a field always read asNonecannot surface that drift.6 unit tests, which
fetch_userhad none of. Reverting the fix fails one of them.🤖 Generated with Claude Code