Fix: Handle nodes with null relation_name - #1
Open
noel wants to merge 2 commits into
Open
Conversation
Skip nodes that have no relation_name (such as dbt operations like on-run-end hooks) to prevent re.sub() from failing with "expected string or bytes-like object" error. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Adds a test to verify that nodes with null relation_name (such as dbt operations like on-run-end hooks) are properly skipped and don't cause "expected string or bytes-like object" errors. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
relation_name(such as dbt operations like on-run-end hooks) to preventre.sub()from failing with "expected string or bytes-like object" errorProblem
When processing dbt manifests that contain operations (like
on-run-endhooks), thebuild_nodes_with_columns()method would crash because these nodes haverelation_name: null. Thenormalize_table_relation_name()function usesre.sub()which requires a string input.Example node that caused the error:
{ "unique_id": "operation.balboa.balboa-on-run-end-0", "resource_type": "model", "relation_name": null, "config": {"materialized": "view"} }Solution
Add a check to skip nodes without
relation_name(unless they're ephemeral models, which construct their relation name differently).Test plan
test_nodes_with_null_relation_name_are_skipped🤖 Generated with Claude Code