acc: Add test reproducing engine=unknown deploy telemetry - #6586
Merged
Conversation
A deploy that fails before deployCore runs still emits a bundle_deploy_event (via the deferred LogDeployTelemetry), but b.Metrics.StateEngine is only set inside deployCore, so it stays at its zero value. resources_metadata is then reported with per-type counts but no state_engine, which the dashboard shows as engine="unknown" - even though the engine was resolved before the failure. The test stubs the workspace filer endpoint to 500 so the deploy fails while acquiring the deployment lock, and captures the resulting telemetry. Co-authored-by: Isaac <no-reply@databricks.com>
denik
enabled auto-merge
September 9, 2026 14:11
pietern
approved these changes
Sep 9, 2026
Collaborator
Integration test reportCommit: f417c2b
Top 8 slowest tests (at least 2 minutes):
|
Collaborator
Integration test reportCommit: f232e77
927 interesting tests: 813 MISS, 113 FAIL, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
alex-khakhlyuk
pushed a commit
to alex-khakhlyuk/cli
that referenced
this pull request
Sep 10, 2026
…s#6587) ## Changes Set `b.Metrics.StateEngine` as soon as the deployment state is pulled, instead of only inside `deployCore`. ## Why Deploy telemetry is emitted on every exit path, but the engine used to be recorded only inside `deployCore`. A deploy that failed or was cancelled before applying resources therefore reported an empty `state_engine`, which the dashboard shows as `engine="unknown"` - even though the engine had already been resolved. ## Tests Stacked on databricks#6586, which added an acceptance test reproducing the empty engine; this PR updates that test to show the engine is now reported per variant. This pull request and its description were written by Isaac. Co-authored-by: Isaac <no-reply@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add an acceptance test that captures a deploy failing before
deployCoreruns (the deployment-lock write is stubbed to 500). Deploy telemetry is still emitted, butresources_metadatacarries per-type counts with nostate_engine.Why
state_engineis only assigned insidedeployCore, so any deploy that fails or is cancelled earlier reports an empty engine, which the telemetry dashboard shows asengine=unknown- even though the engine was resolved long before the failure. This test pins that behavior ahead of the fix.Tests
New acceptance test, passing for both the direct and terraform engines.
This pull request and its description were written by Isaac.