fix(deps)!: pin platform-wallet/dash-sdk to PR #3968 head, adapt to fail-fast load-skip API

Cargo.toml

@@ -18,7 +18,7 @@ qrcode = "0.14.1"
 nix = { version = "0.31.1", features = ["signal"] }
 eframe = { version = "0.35.0", features = ["persistence", "wgpu"] }
 base64 = "0.22.1"
-dash-sdk = { git = "https://github.com/dashpay/platform", branch = "dash-evo-tool", features = [
+dash-sdk = { git = "https://github.com/dashpay/platform", rev = "0503f80df5529b1d4f91e58c49abe08cde7b283f", features = [
     "core_key_wallet",
     "core_key_wallet_manager",
     "core_bincode",
@@ -28,12 +28,12 @@ dash-sdk = { git = "https://github.com/dashpay/platform", branch = "dash-evo-too
     "core_spv",
     "shielded",
 ] }
-rs-sdk-trusted-context-provider = { git = "https://github.com/dashpay/platform", branch = "dash-evo-tool" }
-platform-wallet = { git = "https://github.com/dashpay/platform", branch = "dash-evo-tool", features = [
+rs-sdk-trusted-context-provider = { git = "https://github.com/dashpay/platform", rev = "0503f80df5529b1d4f91e58c49abe08cde7b283f" }
+platform-wallet = { git = "https://github.com/dashpay/platform", rev = "0503f80df5529b1d4f91e58c49abe08cde7b283f", features = [
     "serde",
     "shielded",
 ] }
-platform-wallet-storage = { git = "https://github.com/dashpay/platform", branch = "dash-evo-tool", features = [
+platform-wallet-storage = { git = "https://github.com/dashpay/platform", rev = "0503f80df5529b1d4f91e58c49abe08cde7b283f", features = [
     "shielded",
 ] }
 zip32 = "0.2.0"

src/wallet_backend/dashpay.rs

@@ -814,7 +814,15 @@ impl WalletBackend {
         managed
             .record_dashpay_payment(tx_id, entry, &persister)
             .map_err(|e| TaskError::WalletBackend {
-                source: Box::new(e.into()),
+                // TODO(platform-pr3968): `From<PersistenceError> for
+                // PlatformWalletError` doesn't exist at this rev (no typed
+                // `PersisterLoad(#[from] PersistenceError)` variant yet) —
+                // wrap via the generic `Persistence(String)` variant instead
+                // of `.into()`. Restore the typed conversion once platform
+                // re-adds it.
+                source: Box::new(platform_wallet::error::PlatformWalletError::Persistence(
+                    e.to_string(),
+                )),
             })?;
         Ok(())
     }

src/wallet_backend/event_bridge.rs

@@ -422,20 +422,6 @@ impl PlatformEventHandler for EventBridge {
         self.nudge_refresh();
     }
 
-    fn on_wallet_skipped_on_load(
-        &self,
-        wallet_id: platform_wallet::wallet::platform_wallet::WalletId,
-        reason: &platform_wallet::manager::load_outcome::SkipReason,
-    ) {
-        // Public wallet id + structural reason only; never a secret. The
-        // user-facing banner is raised in `register_persisted_wallets`.
-        tracing::warn!(
-            wallet_id = %hex::encode(wallet_id),
-            %reason,
-            "A saved wallet was skipped on load because its stored data is corrupt"
-        );
-    }
-
     fn on_shielded_sync_progress(&self, cumulative_scanned: u64, block_height: u64) {
         // Downloaded-notes progress for an in-flight pass — drives the
         // shielded tab's "scanning" indicator. Network-scoped (one pass covers

src/wallet_backend/loader.rs

@@ -19,42 +19,21 @@
 //! the load brings back nothing — exactly the funds-invisible state the
 //! W1/W2 writers exist to prevent.
 //!
-//! The outcome types here are DET-opaque: [`LoadedWallets`] carries only
-//! DET's [`WalletSeedHash`] keys and a DET-side [`PersistedLoadSkip`]
-//! reason — no `platform_wallet` / `key_wallet` type crosses the seam.
+//! The outcome type here is DET-opaque: [`LoadedWallets`] carries only
+//! DET's [`WalletSeedHash`] keys — no `platform_wallet` / `key_wallet`
+//! type crosses the seam.
 
 use crate::model::wallet::WalletSeedHash;
 
 /// Outcome of a persisted-wallet load pass, mapped to DET-opaque types.
 ///
-/// Carries no upstream `platform-wallet` type. A non-empty `skipped`
-/// list is still a **success**: a single corrupt persisted row is
-/// reported and the remaining wallets load. A whole-load failure is a
-/// `TaskError` from [`WalletBackend::load_from_persistor_seedless`], not
-/// a populated `skipped`.
+/// Carries no upstream `platform-wallet` type. Any load failure is a
+/// `TaskError` from [`WalletBackend::load_from_persistor_seedless`] — the
+/// upstream load either rebuilds every persisted wallet or fails whole.
 ///
 /// [`WalletBackend::load_from_persistor_seedless`]: super::WalletBackend::load_from_persistor_seedless
 #[derive(Debug, Default, Clone, PartialEq, Eq)]
 pub struct LoadedWallets {
     /// Wallets now registered with the backend, keyed by DET's seed hash.
     pub loaded: Vec<WalletSeedHash>,
-    /// Wallets present on disk but skipped because their persisted row
-    /// was unusable. The [`WalletSeedHash`] is present only when the
-    /// skipped wallet could be matched to a DET sidecar entry; an
-    /// unmatched skip carries `None`.
-    pub skipped: Vec<(Option<WalletSeedHash>, PersistedLoadSkip)>,
-}
-
-/// DET-opaque reason a persisted wallet row was skipped during load.
-///
-/// Mirrors the upstream corrupt-row families without leaking the
-/// upstream `CorruptKind` type or any row-derived bytes.
-#[derive(Debug, Clone, Copy, PartialEq, Eq)]
-pub enum PersistedLoadSkip {
-    /// The wallet row has no usable account manifest to rebuild from.
-    MissingManifest,
-    /// The persisted account xpub failed to parse.
-    MalformedXpub,
-    /// Any other structural decode/projection failure on the row.
-    DecodeError,
 }