fix(ui): include identity name in auth key error banner#747
fix(ui): include identity name in auth key error banner#747thepastaclaw wants to merge 1 commit into
Conversation
The error banner 'Identity doesn't have an authentication key for signing document transitions' now includes the identity alias (or base58 ID as fallback) so users with multiple identities can tell which one is affected. Closes dashpay#743
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe change improves error messaging in identity handling by enhancing the error message displayed when an identity lacks a document-signing key. Instead of showing a generic message, the updated error now includes the identity's label (using alias or base58 id), making it clearer which identity is affected. Import statements are adjusted to support this functionality. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
Superseded by #750 which includes this fix plus suppresses the error on startup auto-select. |
Summary
The error banner "Identity doesn't have an authentication key for signing document transitions" now includes the identity alias (or base58 ID as fallback) so users with multiple identities can tell which one is affected.
Closes #743
Problem
When DET starts and auto-selects an identity that lacks a DPNS document signing key (e.g., an evonode identity), a generic error banner is shown with no indication of which identity triggered it. For users with many identities this is confusing.
Changes
get_selected_wallet()insrc/ui/identities/mod.rsnow includes the identity's alias (or base58 ID) in the error messageIdentityGettersV0import for.id()accessValidation
cargo clippy -p dash-evo-tool --lib— clean, no warningsSummary by CodeRabbit