Skip to content

fix(ui): include identity name in auth key error banner#747

Closed
thepastaclaw wants to merge 1 commit into
dashpay:v1.0-devfrom
thepastaclaw:fix/det-743-auth-key-banner
Closed

fix(ui): include identity name in auth key error banner#747
thepastaclaw wants to merge 1 commit into
dashpay:v1.0-devfrom
thepastaclaw:fix/det-743-auth-key-banner

Conversation

@thepastaclaw

@thepastaclaw thepastaclaw commented Mar 13, 2026

Copy link
Copy Markdown
Collaborator

Summary

The error banner "Identity doesn't have an authentication key for signing document transitions" now includes the identity alias (or base58 ID as fallback) so users with multiple identities can tell which one is affected.

Closes #743

Problem

When DET starts and auto-selects an identity that lacks a DPNS document signing key (e.g., an evonode identity), a generic error banner is shown with no indication of which identity triggered it. For users with many identities this is confusing.

Changes

  • get_selected_wallet() in src/ui/identities/mod.rs now includes the identity's alias (or base58 ID) in the error message
  • Added IdentityGettersV0 import for .id() access

Validation

  • cargo clippy -p dash-evo-tool --lib — clean, no warnings
  • Pre-commit hook passed (fmt + check)
  • Reviewed the single changed file manually

Summary by CodeRabbit

  • Improvements
    • Enhanced error messages when identities lack document-signing keys. Error messages now include the identity label or alias instead of generic text, providing clearer identification during troubleshooting.

The error banner 'Identity doesn't have an authentication key for signing
document transitions' now includes the identity alias (or base58 ID as
fallback) so users with multiple identities can tell which one is affected.

Closes dashpay#743
@coderabbitai

coderabbitai Bot commented Mar 13, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 685f524f-b94d-408c-a662-857c1e7f0a41

📥 Commits

Reviewing files that changed from the base of the PR and between d928288 and 81338a1.

📒 Files selected for processing (1)
  • src/ui/identities/mod.rs

📝 Walkthrough

Walkthrough

The change improves error messaging in identity handling by enhancing the error message displayed when an identity lacks a document-signing key. Instead of showing a generic message, the updated error now includes the identity's label (using alias or base58 id), making it clearer which identity is affected. Import statements are adjusted to support this functionality.

Changes

Cohort / File(s) Summary
Identity Error Enhancement
src/ui/identities/mod.rs
Updated imports to include IdentityGettersV0 from dash_sdk::dpp::identity. Enhanced error handling to construct detailed error messages that include the identity label (alias or base58 id) instead of a static generic message when an identity lacks a document-signing key.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A label for each fuzzy friend,
No mystery till the very end,
Which identity's causing this key situation?
Now the error brings identification!
Clarity hops forth, clear as can be. 🔑

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: enhancing the error banner to include identity name/alias information for better user identification.
Linked Issues check ✅ Passed The code changes directly address issue #743 by embedding identity alias or base58 ID in the error message, allowing users with multiple identities to identify which one lacks the authentication key.
Out of Scope Changes check ✅ Passed All changes are in scope: import additions for IdentityGettersV0 access and error message enhancement with identity identification, both aligned with issue #743 requirements.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@thepastaclaw

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Mar 13, 2026

Copy link
Copy Markdown
Contributor
✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@thepastaclaw

Copy link
Copy Markdown
Collaborator Author

Superseded by #750 which includes this fix plus suppresses the error on startup auto-select.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Identity doesn't have an authentication key for signing document transitions

1 participant