Skip to content

fix: include identity name in auth key missing error messages #745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thepastaclaw wants to merge 2 commits into from
Closed

fix: include identity name in auth key missing error messages #745

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ae508d
fix: include identity name in auth key missing error messages
thepastaclaw Mar 13, 2026
4b01b04
refactor: use ok_or_else for lazy error formatting in DPNS name regis…
thepastaclaw Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/backend_task/identity/register_dpns_name.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,10 +125,12 @@ impl AppContext {

let public_key = qualified_identity
.document_signing_key(&preorder_document_type)
.ok_or(
"Identity doesn't have an authentication key for signing document transitions"
.to_string(),
)?;
.ok_or_else(|| {
format!(
"Identity {} doesn't have an authentication key for signing document transitions",
qualified_identity.display_string()
)
})?;

// Estimate fees for DPNS registration (2 document batch transitions)
let fee_estimator = PlatformFeeEstimator::new();
Expand Down
6 changes: 4 additions & 2 deletions src/ui/identities/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,10 @@ pub fn get_selected_wallet(
qualified_identity
.document_signing_key(&preorder_document_type)
.ok_or_else(|| {
"Identity doesn't have an authentication key for signing document transitions"
.to_string()
format!(
"Identity {} doesn't have an authentication key for signing document transitions",
qualified_identity.display_string()
)
})?
} else {
// Fallback: directly use the provided selected key.
Expand Down