DAOS-19333 build: Don't fail release builds on memcheck - #18747
Open
mjmac wants to merge 2 commits into
Open
Conversation
|
Ticket title is 'NLT can not be run with release binary' |
Collaborator
|
Test stage NLT completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-18747/1/testReport/ |
The memcheck stage uses a separate instrumented build for Go binaries regardless of the BUILD_TYPE value. faults-enabled: false Signed-off-by: Michael MacDonald <github@macdonald.cx>
Release builds compile out fault injection, so the stage has nothing to test and fails on the missing test logs. faults-enabled: false Signed-off-by: Michael MacDonald <github@macdonald.cx>
mjmac
marked this pull request as ready for review
August 3, 2026 14:11
Contributor
Author
|
@grom72: I'm happier with this version. I used |
kjacque
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The memcheck stage uses a separate instrumented build for Go
binaries regardless of the BUILD_TYPE value.
faults-enabled: false
Signed-off-by: Michael MacDonald github@macdonald.cx