Merge #130

[danieljprice]

fixes for p-r #130 so it passes the actions workflows and can be merged

Summary by CodeRabbit

• Bug Fixes
  • Improved lightcurve analysis handling when velocity data is available, ensuring velocity columns are requested only when valid.
  • Fixed FITS image and cube write error handling so reported failures no longer leave the application in an incorrect error state.
  • Cleanup and return processing now continues reliably after FITS output errors.

[coderabbitai]

📝 Walkthrough

Walkthrough

The lightcurve analysis now requests valid velocity columns when available. FITS image and cube write error paths now reset ierr after reporting failures.

Changes

Lightcurve analysis and FITS output handling

Layer / File(s)	Summary
Conditional velocity-column selection src/analysis.f90	open_analysis requests available velocity-component columns for lightcurve when the velocity indices are valid.
FITS write error cleanup src/lightcurve.f90	FITS image and cube write failures now reset ierr after reporting the error. Existing cleanup and return handling continue.

Estimated code review effort: 2 (Simple) | ~5 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title only states that PR #130 is merged and does not describe the lightcurve-generation fixes.	Use a concise title that describes the main changes, such as handling FITS write errors and validating velocity columns.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch merge-130

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/analysis.f90`:
- Line 415: Add the velocity-column upper-bound condition to the
relativistic-correction guard in the lightcurve consumer, alongside its existing
ivx, ndimV, and ipmomx checks, matching the bound used by required. Add a
regression case covering truncated velocity columns and verify the correction
path is disabled without an out-of-bounds read.

In `@src/lightcurve.f90`:
- Around line 353-356: In the error-handling block around the FITS cube write,
update the write statement to use a double-quoted error string and replace the
legacy `endif` terminator with `end if`, preserving the existing logic.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 2f308e67-30f1-4377-9246-299294585b8d

📥 Commits

Reviewing files that changed from the base of the PR and between b0c4c5e and 47c574d.

📒 Files selected for processing (2)

• src/analysis.f90
• src/lightcurve.f90