Skip to content

Fix lightcurve generation: FITS error handling and relativistic NaNs #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danieljprice merged 2 commits into from
Aug 11, 2026
Merged

Fix lightcurve generation: FITS error handling and relativistic NaNs #130

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca43117
Fix lightcurve generation: gracefully handle FITS write errors and en…
Dnsflr Jul 6, 2026
86b16c1
Apply automated review suggestion: add upper bounds check for require…
Dnsflr Jul 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/analysis.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,6 +412,7 @@ subroutine open_analysis(analysistype,required,ncolumns,ndim,ndimV,nsinks)
required(ipmass) = .true.
required(itemp) = .true.
required(ikappa) = .true.
if (ivx > 0) required(ivx:ivx+ndimV-1) = .true.
Comment thread
Dnsflr marked this conversation as resolved.
Outdated
!
!--set filename and header line
!
Expand Down
6 changes: 5 additions & 1 deletion src/lightcurve.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,6 +335,7 @@ subroutine get_lightcurve(ncolumns,dat,npartoftype,masstype,itype,ndim,ntypes,&
call write_fits_image('img_'//trim(specfile)//'_mom0.fits',img,(/npixx,npixy/),ierr)
if (ierr /= 0) then
write(*,"(a)") ' ERROR: mom0 FITS image not written; skipping cube'
ierr = 0
return
endif

Expand All @@ -349,7 +350,10 @@ subroutine get_lightcurve(ncolumns,dat,npartoftype,masstype,itype,ndim,ntypes,&
!$omp end parallel do
call write_fits_cube('img_'//trim(specfile)//'.fits',img_tmp,(/npixx,npixy,nfreq/),ierr)
endif
if (ierr /= 0) write(*,*) 'Error writing to FITS cube !!!'
if (ierr /= 0) then
write(*,*) 'Error writing to FITS cube !!!'
ierr = 0
endif
if (allocated(img_tmp)) deallocate(img_tmp)
endif

Expand Down