Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
?? []) on 45 assertions across 8 test files that were dropped during the xUnit v3 + Shouldly migration, causing 37 test failuresEc2ServiceHandler.csfor consistency (e.g.<tagSet/>to<tagSet></tagSet>)Root Cause
The Shouldly migration (commit a5f31d4) converted patterns like
Assert.Empty(resp.Items ?? [])toresp.Items.ShouldBeEmpty(), dropping the null-coalescing that handled AWS SDK's XML deserialization behavior (empty/absent collection elements deserialize asnull, not empty lists).Test Files Fixed
Ec2Tests.csAlbTests.csSnsTests.csRdsTests.csIamTests.csSesTests.csS3Tests.csPersistenceTests.csAll 1,178 tests pass, 0 failures.