Skip to content

Document release process in CONTRIBUTING.md - #935

Open
Lutika97 wants to merge 2 commits into
dalibo:masterfrom
Lutika97:patch-1
Open

Document release process in CONTRIBUTING.md#935
Lutika97 wants to merge 2 commits into
dalibo:masterfrom
Lutika97:patch-1

Conversation

@Lutika97

Copy link
Copy Markdown

Add release process instructions for versioning and tagging.
Closes #934
Moved release instructions from the wiki into CONTRIBUTING.md so contributors can find release procedures directly in the repository documentation.

Add release process instructions for versioning and tagging.

@MarionGiusti MarionGiusti left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Lutika97 ,

I'm working with @pgiraud. If I may make a few suggestions on your PR:

I think all the content from the wiki is relevant to explain the whole process. Could you please expand the "Build library and tag version" section and also add the "Publish to npm" section ?

I would also keep "How to release?" as the main title instead of "Release process".

Thanks for your contribution to the project!

Added instructions for the release process and how to release the library.
@Lutika97

Copy link
Copy Markdown
Author

Thank you for the review. I've updated the title and added the release instructions, including the Publish to npm section.

Comment thread CONTRIBUTING.md

An index.html file should be added automatically to the release assets by GitHub Action.

### Publish to npm

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm run build-lib
npm publish

Update the codesandboxes demos at https://stackblitz.com/edit/pev2-vanilla and https://stackblitz.com/edit/pev2-vite

Comment thread CONTRIBUTING.md
git push --tags
```


Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep only one blank line.

Comment thread CONTRIBUTING.md

Edit the release changelog on GitHub.

An index.html file should be added automatically to the release assets by GitHub Action.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An index.html file should be added automatically to the release assets by GitHub Actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move release instructions in the CONTRIBUTING

2 participants