Repository navigation
docs: fix 14 typos in comments and documentation - #511
Open
Avicennasis wants to merge 2 commits into
Open
Avicennasis wants to merge 2 commits into
Avicennasis wants to merge 2 commits into
Conversation
ZacharieTFR
reviewed
Sep 30, 2026
| return reject( | ||
| new Error( | ||
| `VAST call canceled – (${this.cappingMinimumTimeInterval})ms minimum interval reached` | ||
| `VAST call canceled – (${this.cappingMinimumTimeInterval})ms minimum interval not reached` |
Contributor
There was a problem hiding this comment.
Suggested change
| `VAST call canceled – (${this.cappingMinimumTimeInterval})ms minimum interval not reached` | |
| `VAST call canceled – (${this.cappingMinimumTimeInterval})ms minimum interval reached` |
Author
There was a problem hiding this comment.
Done — reverted to the original wording in 8f339e1, the 14 typo fixes are untouched. Ready for re-review.
ZacharieTFR
requested changes
Sep 30, 2026
ZacharieTFR
requested changes
Sep 30, 2026
ZacharieTFR
left a comment
ZacharieTFR
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the contribution ! I would suggest to keep the error message like before though 👍
Revert the VAST call canceled message to its original text per review feedback; the typo fixes themselves are unchanged.
Avicennasis
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix 14 typos, grammar errors, and one incorrect error message across 6 files:
src/util/util.js: stray space before period, missing article, wrong pronounsrc/vast_client.js: "fecth" -> "fetch"; "freelunch" -> "FreeLunch" (matchescappingFreeLunchused elsewhere); error message said "minimum interval reached" when the code path is actually the NOT-reached case -- corrected to "minimum interval not reached"src/parser/parser_verification.js: class name typo (VastParser -> VASTParser), gendered pronoun, subject-verb agreement, missing articlesrc/parser/extensions_parser.js: "extentions" -> "extensions"src/util/storage.js: article errorssrc/fetcher/url_handler.js: "occured" -> "occurred", subject-verb agreementNo functional changes except the one corrected error message, which now accurately describes the condition it fires on.