Skip to content

chore: update mutable maps - #170

Merged
ssomayyajula merged 6 commits into
dafny-lang:masterfrom
rishav-karanjit:updateMutableMap
Aug 19, 2025
Merged

chore: update mutable maps #170
ssomayyajula merged 6 commits into
dafny-lang:masterfrom
rishav-karanjit:updateMutableMap

Conversation

@rishav-karanjit

@rishav-karanjit rishav-karanjit commented Aug 15, 2025

Copy link
Copy Markdown
Contributor

updating mutable maps based on: dafny-lang/dafny#5999

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

@rishav-karanjit
rishav-karanjit marked this pull request as ready for review August 18, 2025 17:16
@ssomayyajula

Copy link
Copy Markdown

Because MutableMap is the only extern in libraries, I suppose it's OK for it to be out of sync with DafnyStandardLibraries until we figure out what's going on with dafny-lang/dafny#6333, but I'll let the other reviewer decide.

@ssomayyajula
ssomayyajula self-requested a review August 18, 2025 19:41
@rishav-karanjit

Copy link
Copy Markdown
Contributor Author

Because MutableMap is the only extern in libraries, I suppose it's OK for it to be out of sync with DafnyStandardLibraries until we figure out what's going on with dafny-lang/dafny#6333, but I'll let the other reviewer decide.

Yes. We (from crypto tools) just update it as we need it.

Comment thread src/MutableMap/MutableMap.dfy Outdated
@ssomayyajula

Copy link
Copy Markdown

Since inv is now part of MutableMap, is there any reason why it's not part of the specs as in https://github.com/dafny-lang/dafny/blob/master/Source/DafnyStandardLibraries/src/Std/TargetSpecific/Concurrent-notarget-java-cs-js-go-py.dfy? Do you not need it?

@MikaelMayer MikaelMayer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me

@rishav-karanjit

Copy link
Copy Markdown
Contributor Author

Since inv is now part of MutableMap, is there any reason why it's not part of the specs as in dafny-lang/dafny@master/Source/DafnyStandardLibraries/src/Std/TargetSpecific/Concurrent-notarget-java-cs-js-go-py.dfy? Do you not need it?

Its not part of spec in this PR because I did not needed that in MPL. You can add a suggestion if you recommend it or add it in a different PR. I am fine with either.

@ssomayyajula

Copy link
Copy Markdown

Oh got it, since it's ghost I don't have a problem. Approved

@ssomayyajula
ssomayyajula merged commit b486ff7 into dafny-lang:master Aug 19, 2025
4 checks passed
@rishav-karanjit
rishav-karanjit deleted the updateMutableMap branch August 19, 2025 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants