Skip to content

backend graphql-core v3 adjustments - #2091

Merged
MetRonnie merged 2 commits into
cylc:masterfrom
dwsutherland:backend-graphql-core-v3-changes
Jun 17, 2025
Merged

backend graphql-core v3 adjustments#2091
MetRonnie merged 2 commits into
cylc:masterfrom
dwsutherland:backend-graphql-core-v3-changes

Conversation

@dwsutherland

@dwsutherland dwsutherland commented Mar 10, 2025

Copy link
Copy Markdown
Member

partially addresses cylc/cylc-uiserver#333

Sibling to:
cylc/cylc-flow#6478
cylc/cylc-uiserver#672

Can be merged at any point.

This is a small/minor change to handle the JSON parsing of proper enums introduced with graphql-core v3.

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Tests are included (or explain why tests are not needed).
  • Changelog entry not needed
  • Docs not needed

@oliver-sanders

Copy link
Copy Markdown
Member

It doesn't quite make sense to me, but it does appear to work.

Suggest keeping this PR open until the upstream PRs have been merged so it can adapt if necessary.

@dwsutherland

dwsutherland commented Mar 13, 2025

Copy link
Copy Markdown
Member Author

It doesn't quite make sense to me, but it does appear to work.

Suggest keeping this PR open until the upstream PRs have been merged so it can adapt if necessary.

I think it's something like parsing "Live" in contrast to passing "\"Live\"" as JSON?
As the enum argument value isn't quoted it's just mode: Live not mode: "Live" .. not entirely sure
But the new form of enums definitely tripped it up..

@MetRonnie
MetRonnie self-requested a review March 18, 2025 10:45
Comment thread src/utils/aotf.js Outdated
@MetRonnie MetRonnie modified the milestones: 2.9.0, 2.8.0 Mar 18, 2025
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
@MetRonnie

Copy link
Copy Markdown
Member

We are getting close on the sibling PRs, no reason not to merge this as it is backwards compatible

@MetRonnie
MetRonnie merged commit d4dd9d3 into cylc:master Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants