backend graphql-core v3 adjustments - #2091
Merged
MetRonnie merged 2 commits intoJun 17, 2025
Merged
Conversation
This was referenced Mar 10, 2025
Member
|
It doesn't quite make sense to me, but it does appear to work. Suggest keeping this PR open until the upstream PRs have been merged so it can adapt if necessary. |
Member
Author
I think it's something like parsing |
MetRonnie
self-requested a review
March 18, 2025 10:45
MetRonnie
reviewed
Mar 18, 2025
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
MetRonnie
approved these changes
Mar 20, 2025
oliver-sanders
approved these changes
Jun 12, 2025
Member
|
We are getting close on the sibling PRs, no reason not to merge this as it is backwards compatible |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
partially addresses cylc/cylc-uiserver#333
Sibling to:
cylc/cylc-flow#6478
cylc/cylc-uiserver#672
Can be merged at any point.
This is a small/minor change to handle the JSON parsing of proper enums introduced with graphql-core v3.
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.