Skip to content

Ensure back-supported jinja2 deprecations warn about removal in Cylc 8.8 - #7436

Merged
MetRonnie merged 1 commit into
cylc:8.6.xfrom
MetRonnie:j2-warnings
Sep 2, 2026
Merged

Ensure back-supported jinja2 deprecations warn about removal in Cylc 8.8#7436
MetRonnie merged 1 commit into
cylc:8.6.xfrom
MetRonnie:j2-warnings

Conversation

@MetRonnie

@MetRonnie MetRonnie commented Sep 1, 2026

Copy link
Copy Markdown
Member

Closes #7376

Follow-up to #7365 which made sure any Jinja deprecation warnings are displayed to users. These include a bunch of functions removed in Jinja 3.1, which currently we warn will break in Cylc 8.7.0.

Follow-up to #7325 which provided extended support for some of these functions on master, meaning that the warnings for these should now read 8.8.0.

The solution is simply cherry-picking the extended support from #7325.

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • No dependency changes
  • Tests are included
  • Changelog entry not needed
  • Docs not needed
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

* Back support Jinja2 interfaces deprecated at 3.0 and removed at 3.1.
* Jinja2 renamed a bunch of functions and deprecated their old names.
* Our users didn't spot this as Python warnings are not visible to them.
* As of cylc#7365 (8.6.6) Python warnings
  originating from Jinja2 will be turned into Cylc warnings.
* To provide a migration window, the old function names will be supported
  in Cylc 8.7.x and removed in 8.8.0.
@MetRonnie MetRonnie added this to the 8.6.6 milestone Sep 1, 2026
@MetRonnie MetRonnie self-assigned this Sep 1, 2026
@MetRonnie MetRonnie added the small label Sep 1, 2026
@MetRonnie MetRonnie changed the title Exclude back-supported jinja2 deprecations from warnings Ensure back-supported jinja2 deprecations warn about removal in Cylc 8.8 Sep 1, 2026
@MetRonnie MetRonnie added the sync PR for synchronising changes between 8.*.x and master label Sep 1, 2026

@oliver-sanders oliver-sanders left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think this makes sense, managed to create a right tangle of changes there!

@MetRonnie
MetRonnie merged commit 423f313 into cylc:8.6.x Sep 2, 2026
23 checks passed
@MetRonnie
MetRonnie deleted the j2-warnings branch September 2, 2026 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

small sync PR for synchronising changes between 8.*.x and master

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8.6: followup to 7365

2 participants