Retry cat-log on unreachable platform hosts - #7415
Open
tomatotomata wants to merge 1 commit into
Open
Conversation
Signed-off-by: ahmad <ahmadalgaidy@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4263
cylc cleannow retries another configured host when SSH returns 255.cylc cat-logshould follow the same platform host-selection behavior for remote job logs.This change selects a host explicitly, retries only SSH failures, and preserves the existing process return behavior for directory listing mode. It also adds a regression test and a towncrier note.
Tests:
python -m py_compile cylc/flow/scripts/cat_log.py tests/unit/scripts/test_cat_log.pypwdmodule; CI should exercise it on the supported Unix platforms.I was thinking of keeping the retry at this boundary so other remote command callers are not changed by accident. Let me know what you think.