Skip to content

Improve logging of warnings from Jinja2 processing #7384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oliver-sanders merged 2 commits into from
Aug 25, 2026
Merged

Improve logging of warnings from Jinja2 processing #7384

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e317c63
Improve logging of warnings from Jinja2 lexing
MetRonnie Jul 17, 2026
1219755
Catch additional jinja2 filepath that warnings can come from during p…
MetRonnie Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion changes.d/7365.feat.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
Python warnings raised in users' custom jinja2 filters, globals and tests are now logged.
Python warnings raised during Jinja2 preprocessing are now logged.
7 changes: 7 additions & 0 deletions cylc/flow/parsec/fileparse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,6 +513,13 @@ def read_and_proc(
flines = jinja2process(
fpath, flines, fdir, template_vars
)
for w in warns:
if w.filename.endswith(os.path.join('jinja2', 'lexer.py')):
# Warning originating from lexing of a jinja2 template.
# Unfortunately, we can't know exactly where it originated,
# so just set the config filename and vague line "number":
w.filename = fpath
w.lineno = '<jinja2 template>' # type: ignore
if warns:
LOG.warning(
"The following warnings were raised during Jinja2 "
Expand Down
Loading