schema: remove list default value - #6803
Merged
Merged
Conversation
* This worked under graphene v2 but not v3 for reasons unknown. * However, the default appears to be unnecessary which makes sense since it's `List(LogRecords)` not `List(NonNull(LogRecords))`.
6 tasks
wxtim
reviewed
Jun 19, 2025
wxtim
left a comment
Member
There was a problem hiding this comment.
- Merged with Warning triangles feature branch & master
- Manually tested warning 📐
- Read code
wxtim
self-requested a review
June 19, 2025 14:36
wxtim
approved these changes
Jun 19, 2025
Member
Author
|
I'm going to sneak this in on one review so we can fix master and unblock the UIS PR. @dwsutherland, if you get a chance to take a peek at this one sometime, lemme know if there's any reason we shouldn't fix it this way, cheers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix an integration failure reported in cylc/cylc-uiserver#672 (comment)
List(LogRecords)notList(NonNull(LogRecords)).Reviewer(s), please test the end-to-end functionality of this feature on the graphene v3 branches before approving.
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).?.?.xbranch.