Cylc Config json output mode - #6275
Draft
wxtim wants to merge 5 commits into
Draft
Conversation
8 tasks
wxtim
commented
Aug 5, 2024
wxtim
marked this pull request as draft
August 5, 2024 12:27
wxtim
marked this pull request as ready for review
August 16, 2024 14:21
This comment was marked as resolved.
This comment was marked as resolved.
wxtim
force-pushed
the
feat.parsec_to_json_dumper
branch
from
August 23, 2024 13:29
2d8e721 to
5480b12
Compare
MetRonnie
previously requested changes
Aug 23, 2024
MetRonnie
reviewed
Aug 27, 2024
MetRonnie
reviewed
Aug 27, 2024
wxtim
marked this pull request as draft
August 28, 2024 08:17
Member
Author
|
Drafted pending other work this not being a priority compared to bugfixes. |
wxtim
force-pushed
the
feat.parsec_to_json_dumper
branch
from
August 29, 2024 13:03
f87fcf0 to
02616bc
Compare
wxtim
marked this pull request as ready for review
August 29, 2024 13:03
Member
|
Workflow with implicit task |
MetRonnie
approved these changes
Aug 29, 2024
Member
|
This PR could probably be merged now, however, IMO it's best to keep pairs of PRs open (i.e. unmerged) until the upstream PR has been merged as review comments there could force changes here. Will review together with the upstream PR when both are ready. The upstream PR is currently a draft, so I'll mark this as draft for now to match. |
oliver-sanders
marked this pull request as draft
October 7, 2024 12:57
Member
Author
|
I will get back to this one day, but it's a feature, not a bug... |
wxtim
force-pushed
the
feat.parsec_to_json_dumper
branch
from
March 24, 2025 09:32
5cbdc93 to
c70efd2
Compare
Member
|
(unassigning this to re-focus my review queue, feel free to re-assign when undrafted) |
oliver-sanders
removed their request for review
February 19, 2026 12:53
Response to review - Ensure --json help message is useful. - Make the null value reporting only happen to actual null values. Prevent --json being combined with print.. options Tidy up
wxtim
force-pushed
the
feat.parsec_to_json_dumper
branch
from
March 4, 2026 10:59
754fab4 to
c779021
Compare
oliver-sanders
removed their request for review
March 4, 2026 15:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the following command to Cylc Config:
Required for cylc/cylc-sphinx-extensions#81.
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).?.?.xbranch.