[yamatcha]

#120

[Copilot]

Pull request overview

This PR transitions the repository’s Go linting workflow to golangci-lint (installed via aqua), aligning with the approach used by cybozu-go/moco and updating both local make targets and CI accordingly.

Changes:

• Add golangci-lint to aqua and introduce a .golangci.yml configuration.
• Replace the old make validate pipeline with make lint (and update CI to use it).
• Apply code updates required to satisfy the enabled linters (e.g., errcheck-related close/sync calls, any modernization).

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
server/suite_test.go	Removes prior custom-checker suppression comment now that linting is unified under golangci-lint.
server/mysqld_health.go	Updates error-checking style for rows.Close() (now triggers errcheck considerations).
server/mysqld_health_test.go	Modernizes interface{} to any in test code.
server/initialize.go	Adjusts db.Close() usage to satisfy errcheck.
server/clone.go	Adjusts Close() usage to satisfy errcheck.
Makefile	Replaces validate/tool-install targets with a lint target that runs golangci-lint.
cmd/moco-init/main.go	Adjusts file close handling to satisfy errcheck.
cmd/moco-agent/cmd/root.go	Updates logger interface signature, adds error handling for mysql.SetLogger, and adjusts close/sync defers.
cmd/cp/main.go	Adjusts file close handling to satisfy errcheck.
aqua.yaml	Adds golangci/golangci-lint@v2.12.2.
aqua-checksums.json	Adds checksums for golangci-lint artifacts.
.golangci.yml	Adds golangci-lint v2 configuration and formatter settings.
.github/workflows/ci.yaml	Updates validation job to run make lint and removes prior tool caching steps.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[arosh]

@yamatcha
We should use GetContext in this situation.
https://jmoiron.github.io/sqlx/#getAndSelect

Handling QueryContext correctly is too difficult for humanity 😅