Repository navigation
ci: declare GITHUB_TOKEN permissions in all workflows - #384
Merged
Merged
Conversation
Set the workflow-level default to contents: read and grant write scopes only to the release jobs that need them: packages: write for pushing the container image and contents: write for creating the GitHub release. The CI jobs only check out the repository and run tests, so they do not need any write scope. This is a prerequisite for switching the repository's default GITHUB_TOKEN permissions to read-only.
Merged
terassyi
self-requested a review
September 18, 2026 07:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Declare
GITHUB_TOKENpermissions in both workflows.ci.yaml: workflow-levelcontents: read. The jobs only check out the repository and run tests; none of them calls the GitHub API.release.yaml: workflow-levelcontents: read, pluspackages: writeon theimagejob (docker login + push to ghcr.io) andcontents: writeon thereleasejob (gh release create).Why
The repository currently relies on the default token permissions (
write), and no job declares what it needs. Declaring them per job lets us switch the repository default to read-only afterwards without breaking the release workflow.Checks
upload-artifactandactions/cacheuse the runtime token, notGITHUB_TOKEN, so they are unaffected.aqua-installerdoes not receiveGITHUB_TOKENin these workflows.