Skip to content

V2.7.2mod: dynamic loading for HSL#771

Open
jgillis wants to merge 4 commits into
cvanaret:mainfrom
jgillis:v2.7.2mod
Open

V2.7.2mod: dynamic loading for HSL#771
jgillis wants to merge 4 commits into
cvanaret:mainfrom
jgillis:v2.7.2mod

Conversation

@jgillis

@jgillis jgillis commented Jun 11, 2026

Copy link
Copy Markdown

Hi Charlie!

Finally found some time to get Uno into casadi..

I did some minor modifications to get it more in line with expected behavior from ipopt.
I'm happy to just roll with casadi-patches against your official releases, but you may also chose to merge some of this.

@cvanaret

cvanaret commented Jun 11, 2026

Copy link
Copy Markdown
Owner

Hi Joris,
Thanks for the contribution! Great to see dynamic loading for the HSL solvers.
I will definitely add a reverse CI workflow to run Uno via CasADi, so that we know when changes break.

@amontoison could you have a look when you have a moment?

@amontoison

amontoison commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

Thanks @jgillis for the modifications and working on an interface for CasADi!

A few comments:

  • I am a big fan of the dynamic loader for HSL.
    For Julia, it is easy to do hot-swapping, so I precompile a dummy version of libHSL with the required symbols such that the
    linker is happy, and at runtime we call the routine LIBHSL_ISFUNCTIONAL() to check what is available. It works quite well when the
    user has access to the installation folder, because they can replace libhsl.$dlext on their own.
    So it's quite nice when the user downloads the precompiled artifacts from GitHub. Julia does that automatically too with HSL_jll.jl.
    But your approach is the best one if Uno is installed through some other way like PyPI, Homebrew, a Linux distribution, etc. We can't easily hot-swap the library.

  • For METIS, why are you not using -DAUXILIARY_LIBRARIES?
    It is dedicated to dependencies of dependencies for static builds.

  • For the header of SPRAL / SSIDS, Charlie made a modification to add a CMake variable but it never landed in main. Are these modifications enough for you?

@cvanaret cvanaret changed the title V2.7.2mod V2.7.2mod: dynamic loading for HSL + improved build Jun 12, 2026
@cvanaret

cvanaret commented Jun 17, 2026

Copy link
Copy Markdown
Owner

The CMake variable SPRAL_INCLUDE_DIRis now available (see #779). I have updated the PR and simplified the CMake a bit.
As Alexis wrote, we can handle METIS via AUXILIARY_LIBRARIES. I'll do a proper read of the dynamic loader in the next few days.

@cvanaret

cvanaret commented Jun 23, 2026

Copy link
Copy Markdown
Owner

Hi @jgillis, I have merged a separate PR (#792) to optionally build with OpenMP, and updated your branch.
I'm working on a paper review at the moment (due Thursday), so I'll have a look at the dynamic loader at the end of the week.

cvanaret
cvanaret reviewed Jun 30, 2026
View reviewed changes
Comment thread uno/ingredients/subproblem_solvers/HSL/HSLLoader.cpp
}

template <typename FunctionPointer>
void resolve(LibraryHandle handle, FunctionPointer& function_pointer, const std::string& base) {

@cvanaret cvanaret Jun 30, 2026

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move to .hpp

cvanaret
cvanaret reviewed Jun 30, 2026
View reviewed changes
Comment thread uno/ingredients/subproblem_solvers/HSL/HSLLoader.cpp
for (char& c: upper) { c = static_cast<char>(std::toupper(static_cast<unsigned char>(c))); }
const std::string candidates[] = {base, base + "_", lower + "_", lower, upper + "_", upper};
for (const std::string& candidate: candidates) {
if (void* symbol = raw_symbol(handle, candidate.c_str())) {

@cvanaret cvanaret Jun 30, 2026

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improve syntax (two lines)

cvanaret
cvanaret reviewed Jun 30, 2026
View reviewed changes
Comment thread uno/ingredients/subproblem_solvers/HSL/HSLLoader.cpp

std::string name = library_name;
if (name.empty()) {
if (const char* env = std::getenv("UNO_HSL_LIBRARY")) {

@cvanaret cvanaret Jun 30, 2026

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improve syntax (two lines)

cvanaret
cvanaret reviewed Jun 30, 2026
View reviewed changes
Comment thread CMakeLists.txt Outdated
@cvanaret

cvanaret commented Jun 30, 2026

Copy link
Copy Markdown
Owner

Hi @jgillis, I've added a few comments (which I'm happy to address in a subsequent PR). The main change would be to link METIS via AUXILIARY_LIBRARIES.
On my way to rebase.

@cvanaret cvanaret changed the title V2.7.2mod: dynamic loading for HSL + improved build V2.7.2mod: dynamic loading for HSL Jun 30, 2026
@cvanaret

cvanaret commented Jun 30, 2026

Copy link
Copy Markdown
Owner

@amontoison good for you too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cvanaret cvanaret cvanaret approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jgillis @cvanaret @amontoison