Update dependency versions - #3355
Conversation
github-actions
Bot
added
the
lines/1000+
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 833252815a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "cross-spawn": "^7.0.6", | ||
| "mocha": "^11.8.0", | ||
| "tsx": "^4.23.12" | ||
| "mocha": "^12.0.0", |
There was a problem hiding this comment.
The required legacy job in .github/workflows/test.yml runs the bundled test runner inside VS Code 1.98, whose extension host uses Node 20.18.x, but Mocha 12 declares support only for Node ^20.19.0 || >=22.12.0 in this commit's lockfile. Because scripts/compile-esbuild.sh bundles Mocha into extensionTestsVscode.cjs, the workflow's Node 24 setup does not protect it once VS Code loads the runner; this leaves the branch-protection job executing Mocha on an unsupported runtime and liable to fail before tests run. Keep Mocha 11 or raise the legacy VS Code version to one with a supported Node runtime.
Useful? React with 👍 / 👎.
1 participant
No description provided.