Skip to content

Improved tutorial definitions for better docs inclusion - #3342

Merged
AndreasArvidsson merged 5 commits into
mainfrom
tutorialdocs
Sep 4, 2026
Merged

AndreasArvidsson merged 5 commits into
mainfrom
tutorialdocs

Conversation

@AndreasArvidsson

Copy link
Copy Markdown
Member

No description provided.

@AndreasArvidsson
AndreasArvidsson requested a review from a team as a code owner September 4, 2026 11:20
@AndreasArvidsson

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-04T11:47:46.188267Z ae2f24b New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: 646eefc196

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@AndreasArvidsson
AndreasArvidsson merged commit 9da7941 into main Sep 4, 2026
13 of 15 checks passed
@AndreasArvidsson
AndreasArvidsson deleted the tutorialdocs branch September 4, 2026 11:40

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ae2f24bf20

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@@ -1,12 +1,14 @@
export type TutorialId = "tutorial-1-basics" | "tutorial-2-basic-coding";
export type TutorialId =
| "1-introduction"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep accepting the legacy introduction tutorial ID

When the VS Code extension updates before the user's separately installed Talon files, saying "cursorless tutorial" still invokes cursorless.tutorial.start with "tutorial-1-basics". That value reaches TutorialImpl.start, but the renamed tutorial list contains no match, so getRawTutorial() returns undefined and loadTutorial() throws while accessing rawContent.title; the tutorial therefore cannot start until Talon is also updated. Preserve an alias from the previously accepted ID to "1-introduction" at the command boundary.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant