Improved tutorial definitions for better docs inclusion - #3342
Conversation
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ae2f24bf20
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1,12 +1,14 @@ | |||
| export type TutorialId = "tutorial-1-basics" | "tutorial-2-basic-coding"; | |||
| export type TutorialId = | |||
| | "1-introduction" | |||
There was a problem hiding this comment.
Keep accepting the legacy introduction tutorial ID
When the VS Code extension updates before the user's separately installed Talon files, saying "cursorless tutorial" still invokes cursorless.tutorial.start with "tutorial-1-basics". That value reaches TutorialImpl.start, but the renamed tutorial list contains no match, so getRawTutorial() returns undefined and loadTutorial() throws while accessing rawContent.title; the tutorial therefore cannot start until Talon is also updated. Preserve an alias from the previously accepted ID to "1-introduction" at the command boundary.
Useful? React with 👍 / 👎.
No description provided.