Repository navigation
fix(pstack): list reflect transcripts when a layout is missing - #880
Open
rudycelekli wants to merge 1 commit into
Open
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
zsh aborts the listing on the first unmatched pattern and the pipe to head still exits 0, so an existing transcript is skipped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reflect lists transcripts with one ls across the flat, nested, and subagent layouts, then pipes it to head. On zsh, the default shell on a Mac, an unmatched glob is an error. A conversation that only has the nested id/id.jsonl file still misses the flat and subagent patterns, so zsh prints no matches found, lists nothing, and exits 0 because head is the last stage of the pipe. The transcript that exists is skipped, and the skill then treats the session as if it had no log.
The listing now runs in bash with nullglob, so a layout that is not on disk is dropped and ls -t still prints the files that are there. The same command also survives failglob, which is bash's version of that abort.
The regression test runs the skill's command against a directory that has only the nested transcript. Under bash failglob and under zsh -f, origin/main prints no match and no path. After this change both print the nested file and exit 0. Plugin validation, the harness check, and git diff --check pass.