Repository navigation
fix(pstack): tell poteto-agent how to find poteto-mode's SKILL.md - #569
Open
darkhan-nace wants to merge 2 commits into
Open
darkhan-nace wants to merge 2 commits into
darkhan-nace wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
poteto-agenttells the subagent to read thepoteto-modeskill'sSKILL.md, but it doesn't say where that file is. If the subagent doesn't already have the path in its context, it has to search for it, and the obvious searches fail:target_directoryorpathoutside it, they quietly search the workspace instead. Asking Glob forSKILL.mdin the pstack cache folder returned the open repo's.agents/skills/*/SKILL.md. Grep's result is labelled with the workspace path. So**/poteto-mode/SKILL.mdreturns 0 files from~,~/.cursor/pluginsor the pstack folder.lswith several globs aborts in zsh. If any one glob matches nothing, zsh fails the whole command withno matches foundbeforelsruns.2>/dev/nulldoesn't help.In one run, a reviewer subagent tried both, then reported "the poteto-mode skill does not exist anywhere on this machine" and worked without it. The file was at
~/.cursor/plugins/cache/cursor-public/pstack/<sha>/skills/poteto-mode/SKILL.md.This change adds one paragraph to the agent:
find ~/.cursor/plugins -path '*pstack*/skills/poteto-mode/SKILL.md'. The quoted pattern behaves the same in bash and zsh, and still matches after a version bump or a different marketplace name.principle-*skills next to it.It also bumps pstack to 0.15.18.
Checked.
node scripts/validate-plugins.mjspasses.findcommand prints the installed path in both bash and zsh./private/tmp(no.gitignore, not a git repo) both searched the workspace instead.fdandrg --filesalso find the skill, but neither ships with macOS, and Debian installsfdasfdfind, so the agent uses POSIXfind.Note
Low Risk
Documentation-only agent prompt change and a patch version bump; no runtime code or security-sensitive behavior.
Overview
Bumps pstack to
0.15.18and extendspoteto-agentso subagents can reliably loadpoteto-modewhen the parent did not pass a path.The new instructions tell the agent to prefer a parent-supplied
SKILL.mdpath, otherwise run POSIXfindunder~/.cursor/pluginsfor*pstack*/skills/poteto-mode/SKILL.md, read the newest match, and locate siblingprinciple-*skills there. It explicitly forbids Glob/Grep for this lookup (they only search the open workspace) and requires reporting thefindcommand on failure instead of claiming the skill is missing.Reviewed by Cursor Bugbot for commit 1a30540. Bugbot is set up for automated code reviews on this repo. Configure here.