compatiable ror bitmap rdb type - #1079
Open
jackjeyis wants to merge 7 commits into
Open
Conversation
LanternLee
approved these changes
Jul 20, 2026
| new byte[][]{RedisOpType.SET.name().getBytes(), context.getKey().get(), value}, | ||
| context.getKey(), value)); | ||
|
|
||
| if(this.context.getRdbVersion() > 9) { |
added 2 commits
July 20, 2026 19:13
LanternLee
reviewed
Jul 22, 2026
| return NON_KEY_COMMANDS.contains(ByteBuffer.wrap(args)); | ||
| } | ||
|
|
||
| private boolean usesFieldsSyntax(RedisOpType opType) { |
| private static final Map<Integer,Map<Short, RdbType>> versionTypes = new HashMap<>(); | ||
|
|
||
| RdbType(short code, boolean rdbOp, Function<RdbParseContext, RdbParser> parserConstructor) { | ||
| this.version = 0; |
Collaborator
There was a problem hiding this comment.
复用RdbType(int version,short code, boolean rdbOp, Function<RdbParseContext, RdbParser> parserConstructor)？
LanternLee
reviewed
Jul 23, 2026
|
|
||
| int i = keyStartIndex; | ||
| while (i < args.length) { | ||
| int argLen = args.length; |
Collaborator
There was a problem hiding this comment.
扫一下8.0注册了getkeyrequests_proc的命令，如果都符合可以用这种写法；否则可以参考下Redis的写法，对于特殊的key获取定义方法注册到命令定义枚举
| return NON_KEY_COMMANDS.contains(ByteBuffer.wrap(args)); | ||
| } | ||
|
|
||
| private RedisOp parseFieldsCommand(RedisOpType opType, byte[][] args) { |
Collaborator
There was a problem hiding this comment.
和parseGeneralCommands的关系？
LanternLee
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.