-
Notifications
You must be signed in to change notification settings - Fork 16
Feature: add \shards command to track relocations #494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mannreis
wants to merge
20
commits into
crate:main
Choose a base branch
from
mannreis:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
22bd78b
feat: add new command \shards [all]
mannreis 4146fdf
feat: change \shards [state|relocating]
mannreis 880223e
tests: add ShardsCommand tests
mannreis 2786f0a
tests: add basic integration tests
mannreis 022c19b
chore: update CHANGES.txt with `\shards` feature
mannreis e661b1f
feat: \shards shows tables relocating first
mannreis 2924468
Apply suggestion from @seut
mannreis bb2eed7
Apply suggestion from @seut
mannreis cbca86d
Address suggestion to remove `shards relocating` cmd/query
mannreis 4300264
Address sugestion to make "\shards state" default
mannreis 09490b6
chore: adjust shards command description
mannreis b5b80b6
patch: fix issue with evaluating 1024 ^ 3
mannreis 210445e
tests: fix and rename tests to match suggestions
mannreis e097681
misc: formating
mannreis 5d8a4aa
Merge branch 'main' into main
florinutz 980ce2d
Apply typo fixes
mannreis bdc9426
chore: update CHANGES.txt with `\shards` feature
mannreis 0912903
Adjust docs to match new cmd
mannreis a1a5d48
Adjust release changes
mannreis 7c8fae0
Merge remote-tracking branch 'upstream/main'
mannreis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -56,6 +56,12 @@ Every command starts with a ``\`` character. | |||||||||
| | ``\r <FILENAME>`` | Reads statements from ``<FILENAME>`` and execute | | ||||||||||
| | | them. | | ||||||||||
| +------------------------+-----------------------------------------------------+ | ||||||||||
| | ``\shards [VIEW]`` | Queries ``sys.shards`` table and computes relocation| | ||||||||||
|
mannreis marked this conversation as resolved.
Outdated
|
||||||||||
| | | progress progress per table. If ``VIEW`` is instead:| | ||||||||||
| | | | | ||||||||||
| | | - ``state`` provides aggregeration on shard state | | ||||||||||
| | | - ``relocating`` tracks which shards are relocated | | ||||||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||
| +------------------------+-----------------------------------------------------+ | ||||||||||
| | ``\sysinfo`` | Query the ``sys`` tables for system and cluster | | ||||||||||
| | | information. | | ||||||||||
| +------------------------+-----------------------------------------------------+ | ||||||||||
|
|
||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.