Skip to content

live-booting: mention new coreos.liveiso.fromram kernel argument#577

Merged
dustymabe merged 1 commit into
coreos:mainfrom
dustymabe:dusty-live-booting
Aug 23, 2023
Merged

live-booting: mention new coreos.liveiso.fromram kernel argument#577
dustymabe merged 1 commit into
coreos:mainfrom
dustymabe:dusty-live-booting

Conversation

@dustymabe

Copy link
Copy Markdown
Member

@Floris497 Floris497 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and works

@travier

travier commented Aug 23, 2023

Copy link
Copy Markdown
Member

Wondering if we should make that a separated example to make it clearer that it's not needed / not the default.

@dustymabe

Copy link
Copy Markdown
Member Author

Wondering if we should make that a separated example to make it clearer that it's not needed / not the default.

I started out this way. In fact I had it all written out and ready to submit. Then I realized that if we have two examples and one of them being optional the -o customized.iso fedora-coreos-{stable-version}-live.x86_64.iso doesn't really work so well. You'd need to add a first step that copies fedora-coreos-{stable-version}-live.x86_64.iso to customized.iso and then operate directly on that for both customize calls.

Ultimately I ended up here. Definitely open to suggestions.

@travier travier left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM :)

@dustymabe dustymabe merged commit 084fb4c into coreos:main Aug 23, 2023
@dustymabe dustymabe deleted the dusty-live-booting branch August 23, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants